From: Chris Wilson <chris@chris-wilson.co.uk>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Switch off FBC when disabling the primary plane when obscured
Date: Tue, 12 Jun 2012 21:30:22 +0100 [thread overview]
Message-ID: <1339533031_13161@CP5-2952> (raw)
In-Reply-To: <20120612072804.2ce5f1a8@jbarnes-desktop>
On Tue, 12 Jun 2012 07:28:04 -0700, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> Though now we have 3 "active" state variables for the crtc don't we?
> active, enabled, and now primary_disabled? Oh and dpms state. I
> really wish we could get rid of 2 or 3 of those...</dreaming>
That crossed my mind as well. This felt like it was an orthogonal
property of the crtc, though in reality if we disable the crtc we will
disable the sprites as well so there is a dependence. Given how quickly
the dream of reducing the number of active/enabled/disabled/dpms_mode
states turns into a nightmare, I felt a certain reticient to attempting
it. Perhaps our in-house dragon tamer may like to give it a shot?
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-06-12 20:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-12 11:46 [PATCH] drm/i915: Switch off FBC when disabling the primary plane when obscured Chris Wilson
2012-06-12 13:03 ` Jani Nikula
2012-06-12 14:28 ` Jesse Barnes
2012-06-12 20:30 ` Chris Wilson [this message]
2012-06-13 10:45 ` Daniel Vetter
2012-06-13 11:18 ` Chris Wilson
2012-06-13 11:40 ` Daniel Vetter
2012-06-13 14:29 ` Daniel Vetter
2012-06-13 16:36 ` Chris Wilson
2012-06-13 18:10 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1339533031_13161@CP5-2952 \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox