From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Switch off FBC when disabling the primary plane when obscured
Date: Tue, 12 Jun 2012 07:28:04 -0700 [thread overview]
Message-ID: <20120612072804.2ce5f1a8@jbarnes-desktop> (raw)
In-Reply-To: <1339501560-31685-1-git-send-email-chris@chris-wilson.co.uk>
On Tue, 12 Jun 2012 12:46:00 +0100
Chris Wilson <chris@chris-wilson.co.uk> wrote:
> As we switch on/off the primary plane if it is completely obscured by an
> overlapping video sprite, we also nee to make sure that we update the
> FBC configuration at the same time.
>
> References: https://bugs.freedesktop.org/show_bug.cgi?id=50238
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
> ---
Yeah looks good.
Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Though now we have 3 "active" state variables for the crtc don't we?
active, enabled, and now primary_disabled? Oh and dpms state. I
really wish we could get rid of 2 or 3 of those...</dreaming>
Jesse
next prev parent reply other threads:[~2012-06-12 14:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-12 11:46 [PATCH] drm/i915: Switch off FBC when disabling the primary plane when obscured Chris Wilson
2012-06-12 13:03 ` Jani Nikula
2012-06-12 14:28 ` Jesse Barnes [this message]
2012-06-12 20:30 ` Chris Wilson
2012-06-13 10:45 ` Daniel Vetter
2012-06-13 11:18 ` Chris Wilson
2012-06-13 11:40 ` Daniel Vetter
2012-06-13 14:29 ` Daniel Vetter
2012-06-13 16:36 ` Chris Wilson
2012-06-13 18:10 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120612072804.2ce5f1a8@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox