From: Chris Wilson <chris@chris-wilson.co.uk>
To: eugeni.dodonov@intel.com, Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 0/3] kill /dev/agpgart, v2
Date: Mon, 25 Jun 2012 12:22:55 +0100 [thread overview]
Message-ID: <1340623412_65391@CP5-2952> (raw)
In-Reply-To: <4FE79A6D.2060105@linux.intel.com>
On Sun, 24 Jun 2012 19:53:33 -0300, Eugeni Dodonov <eugeni.dodonov@linux.intel.com> wrote:
> On 06/24/2012 03:51 PM, Daniel Vetter wrote:
> > Hi all,
> >
> > Well, only for gen6+, and now with Dave's suggestion implemented to tell drm
> > core that we don't need agp. It's ugly and I really prefer if we'd kill the drm
> > agp midlayer stuff instead. But this way we can go forward with moving gen6+ gtt
> > stuff to drm/i915 and implementing some neat new cool things.
> >
> > As usual, flames&bikesheds highly welcome.
>
> I cannot think on a less invasive way to do so, so, for the series:
> Reviewed-by: Eugeni Dodonov <eugeni.dodonov@intel.com>
>
> With just one tiny bikeshed on patch2.
Agreed, except that it is not just bikeshedding on patch too. Without
any hint as to why gen3 is special, both in the changelog and justifying
the code as a comment (remember the comments are to explain why!), the
patch is NAKed.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
prev parent reply other threads:[~2012-06-25 11:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-24 18:51 [PATCH 0/3] kill /dev/agpgart, v2 Daniel Vetter
2012-06-24 18:51 ` [PATCH 1/3] drm/i915: don't use dev->agp Daniel Vetter
2012-06-24 18:51 ` [PATCH 2/3] drm/i915: disable drm agp support for !gen3 with kms enabled Daniel Vetter
2012-06-24 22:57 ` Eugeni Dodonov
2012-06-25 7:22 ` Daniel Vetter
2012-06-25 13:58 ` [PATCH] " Daniel Vetter
2012-06-25 15:18 ` Chris Wilson
2012-06-25 19:11 ` Daniel Vetter
2012-06-25 15:47 ` Eugeni Dodonov
2012-06-24 18:51 ` [PATCH 3/3] agp/intel-agp: remove snb+ host bridge pciids Daniel Vetter
2012-06-24 22:53 ` [PATCH 0/3] kill /dev/agpgart, v2 Eugeni Dodonov
2012-06-25 11:22 ` Chris Wilson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340623412_65391@CP5-2952 \
--to=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=eugeni.dodonov@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox