public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Eugeni Dodonov <eugeni.dodonov@linux.intel.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: disable drm agp support for !gen3 with kms enabled
Date: Mon, 25 Jun 2012 12:47:28 -0300	[thread overview]
Message-ID: <4FE88810.3000604@linux.intel.com> (raw)
In-Reply-To: <1340632729-6048-1-git-send-email-daniel.vetter@ffwll.ch>

On 06/25/2012 10:58 AM, Daniel Vetter wrote:
> This is the quick&dirty way Dave Airlie suggested to workaround the
> midlayer drm agp brain-damange. Note that i915_probe is only called
> when the driver has ksm enabled, so no need to check for that.
> 
> We also need to move the intel_agp_enabled check at the right place.
> Note that the only thing this does is enforce the correct module load
> order (by using a symbol from intel-agp.ko) to ensure that the fake
> agp driver is ready before the drm core tries to set up the agp stuff.
> 
> v2: Add a comment to explain why gen3 needs all this legacy fake agp
> stuff - we've shipped an XvMC library with a kms-enabled ddx that
> requires it (but only on gen3).
> 
> v3: Make it clear that this is really a gen3 issue only in the
> comment.
> 
> Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Reviewed-by: Eugeni Dodonov <eugeni.dodonov@intel.com>

Eugeni

  parent reply	other threads:[~2012-06-25 15:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-24 18:51 [PATCH 0/3] kill /dev/agpgart, v2 Daniel Vetter
2012-06-24 18:51 ` [PATCH 1/3] drm/i915: don't use dev->agp Daniel Vetter
2012-06-24 18:51 ` [PATCH 2/3] drm/i915: disable drm agp support for !gen3 with kms enabled Daniel Vetter
2012-06-24 22:57   ` Eugeni Dodonov
2012-06-25  7:22     ` Daniel Vetter
2012-06-25 13:58       ` [PATCH] " Daniel Vetter
2012-06-25 15:18         ` Chris Wilson
2012-06-25 19:11           ` Daniel Vetter
2012-06-25 15:47         ` Eugeni Dodonov [this message]
2012-06-24 18:51 ` [PATCH 3/3] agp/intel-agp: remove snb+ host bridge pciids Daniel Vetter
2012-06-24 22:53 ` [PATCH 0/3] kill /dev/agpgart, v2 Eugeni Dodonov
2012-06-25 11:22   ` Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FE88810.3000604@linux.intel.com \
    --to=eugeni.dodonov@linux.intel.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=eugeni.dodonov@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox