From: Eugeni Dodonov <eugeni.dodonov@linux.intel.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 2/3] drm/i915: disable drm agp support for !gen3 with kms enabled
Date: Sun, 24 Jun 2012 19:57:26 -0300 [thread overview]
Message-ID: <4FE79B56.7070903@linux.intel.com> (raw)
In-Reply-To: <1340563898-3687-3-git-send-email-daniel.vetter@ffwll.ch>
On 06/24/2012 03:51 PM, Daniel Vetter wrote:
> + /* Only enable AGP support for gen 3. */
> + if (intel_info->gen != 3) {
> + driver.driver_features &=
> + ~(DRIVER_USE_AGP | DRIVER_REQUIRE_AGP);
> + } else if (!intel_agp_enabled) {
> + DRM_ERROR("drm/i915 can't work without intel_agp module!\n");
> + return -ENODEV;
> + }
> +
<bikeshed>
For the future generations of developers to touch gen3 (or something
older than gen3 :)), I'd suggest to expand the comment to explain why we
need it on gen3 and not on all the other gens. I haven't seen this
commented in any other agpgart killing patches, so perhaps this would be
the best place.
</bikeshed>
Eugeni
next prev parent reply other threads:[~2012-06-24 22:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-24 18:51 [PATCH 0/3] kill /dev/agpgart, v2 Daniel Vetter
2012-06-24 18:51 ` [PATCH 1/3] drm/i915: don't use dev->agp Daniel Vetter
2012-06-24 18:51 ` [PATCH 2/3] drm/i915: disable drm agp support for !gen3 with kms enabled Daniel Vetter
2012-06-24 22:57 ` Eugeni Dodonov [this message]
2012-06-25 7:22 ` Daniel Vetter
2012-06-25 13:58 ` [PATCH] " Daniel Vetter
2012-06-25 15:18 ` Chris Wilson
2012-06-25 19:11 ` Daniel Vetter
2012-06-25 15:47 ` Eugeni Dodonov
2012-06-24 18:51 ` [PATCH 3/3] agp/intel-agp: remove snb+ host bridge pciids Daniel Vetter
2012-06-24 22:53 ` [PATCH 0/3] kill /dev/agpgart, v2 Eugeni Dodonov
2012-06-25 11:22 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE79B56.7070903@linux.intel.com \
--to=eugeni.dodonov@linux.intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=eugeni.dodonov@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox