From: Imre Deak <imre.deak@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 1/4] drm/i915: add msecs_to_jiffies_timeout to guarantee minimum duration
Date: Tue, 21 May 2013 20:03:17 +0300 [thread overview]
Message-ID: <1369155800-19654-1-git-send-email-imre.deak@intel.com> (raw)
We need this to avoid premature timeouts whenever scheduling a timeout
based on the current jiffies value. For an explanation see [1].
The following patches will take the helper into use.
Once the more generic solution proposed in the thread at [1] is accepted
this patch can be reverted while keeping the follow-up patches.
[1] http://marc.info/?l=linux-kernel&m=136854294730957&w=2
Signed-off-by: Imre Deak <imre.deak@intel.com>
---
drivers/gpu/drm/i915/i915_drv.h | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 639ec0b..78b6c56 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -1981,4 +1981,19 @@ static inline void __user *to_user_ptr(u64 address)
return (void __user *)(uintptr_t)address;
}
+static inline unsigned long msecs_to_jiffies_timeout(const unsigned int m)
+{
+ unsigned long j = msecs_to_jiffies(m);
+
+ return min_t(unsigned long, MAX_JIFFY_OFFSET, j + 1);
+}
+
+static inline unsigned long
+timespec_to_jiffies_timeout(const struct timespec *value)
+{
+ unsigned long j = timespec_to_jiffies(value);
+
+ return min_t(unsigned long, MAX_JIFFY_OFFSET, j + 1);
+}
+
#endif
--
1.8.1.2
next reply other threads:[~2013-05-21 17:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-21 17:03 Imre Deak [this message]
2013-05-21 17:03 ` [PATCH 2/4] drm/i915: use msecs_to_jiffies_timeout instead of open coding the same Imre Deak
2013-05-21 17:20 ` Daniel Vetter
2013-05-21 18:00 ` Imre Deak
2013-05-21 18:20 ` Daniel Vetter
2013-05-21 17:03 ` [PATCH 3/4] drm/i915: avoid premature timeouts in __wait_seqno() Imre Deak
2013-05-21 17:03 ` [PATCH 4/4] drm/i915: avoid premature DP AUX timeouts Imre Deak
2013-05-22 7:48 ` [PATCH 1/4] drm/i915: add msecs_to_jiffies_timeout to guarantee minimum duration Jani Nikula
2013-05-22 9:46 ` Daniel Vetter
2013-05-22 9:57 ` Imre Deak
2013-05-22 11:51 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369155800-19654-1-git-send-email-imre.deak@intel.com \
--to=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox