Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Imre Deak <imre.deak@intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 1/4] drm/i915: add msecs_to_jiffies_timeout to guarantee minimum duration
Date: Wed, 22 May 2013 12:57:01 +0300	[thread overview]
Message-ID: <1369216621.24656.7.camel@intelbox> (raw)
In-Reply-To: <CAKMK7uFYZ_KUWyzUvW=XnOzB78k5yRnt=O1Ou7Tw0EZgYLg=LA@mail.gmail.com>

On Wed, 2013-05-22 at 11:46 +0200, Daniel Vetter wrote:
> On Wed, May 22, 2013 at 9:48 AM, Jani Nikula
> <jani.nikula@linux.intel.com> wrote:
> > On Tue, 21 May 2013, Imre Deak <imre.deak@intel.com> wrote:
> >> We need this to avoid premature timeouts whenever scheduling a timeout
> >> based on the current jiffies value. For an explanation see [1].
> >> The following patches will take the helper into use.
> >>
> >> Once the more generic solution proposed in the thread at [1] is accepted
> >> this patch can be reverted while keeping the follow-up patches.
> >>
> >> [1] http://marc.info/?l=linux-kernel&m=136854294730957&w=2
> >
> > With the name clashes, what happens when the generic solution is merged?
> > Blows up the build? To avoid confusion with merging upstream and
> > potential stable backports, should we err on the safe side and rename
> > these? Or add suitable trickery to use the generic version when
> > available?
> 
> linux-next should catch such fallout and we can fix up things in the
> merge. And since Linus has intel graphics I expect that he'll catch it
> if it fails to compile ;-)

Yea, I haven't thought this through properly. But after discussing with
Jani, this seems to be doable. I only hope Linus won't have to resolve
anything :)

--Imre

  reply	other threads:[~2013-05-22  9:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-21 17:03 [PATCH 1/4] drm/i915: add msecs_to_jiffies_timeout to guarantee minimum duration Imre Deak
2013-05-21 17:03 ` [PATCH 2/4] drm/i915: use msecs_to_jiffies_timeout instead of open coding the same Imre Deak
2013-05-21 17:20   ` Daniel Vetter
2013-05-21 18:00     ` Imre Deak
2013-05-21 18:20       ` Daniel Vetter
2013-05-21 17:03 ` [PATCH 3/4] drm/i915: avoid premature timeouts in __wait_seqno() Imre Deak
2013-05-21 17:03 ` [PATCH 4/4] drm/i915: avoid premature DP AUX timeouts Imre Deak
2013-05-22  7:48 ` [PATCH 1/4] drm/i915: add msecs_to_jiffies_timeout to guarantee minimum duration Jani Nikula
2013-05-22  9:46   ` Daniel Vetter
2013-05-22  9:57     ` Imre Deak [this message]
2013-05-22 11:51       ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1369216621.24656.7.camel@intelbox \
    --to=imre.deak@intel.com \
    --cc=daniel@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox