From: Imre Deak <imre.deak@intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 2/4] drm/i915: use msecs_to_jiffies_timeout instead of open coding the same
Date: Tue, 21 May 2013 21:00:49 +0300 [thread overview]
Message-ID: <1369159249.944.3.camel@ideak-mobl> (raw)
In-Reply-To: <CAKMK7uHpc48xuQKSmEe2wWDAxnn97O0RSfNZ9hmeTX=5KAskiA@mail.gmail.com>
On Tue, 2013-05-21 at 19:20 +0200, Daniel Vetter wrote:
> We have another one of these in the wait_for register wait macro in
> intel_drv.h Can you please amend your patch with that fixed up, too?
I noticed it, but didn't change it since we don't need there the +1
adjustment to begin with. The time_after() check already makes sure we
wait at least MS amount. So I think we should remove +1 from there..
--Imre
next prev parent reply other threads:[~2013-05-21 18:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-21 17:03 [PATCH 1/4] drm/i915: add msecs_to_jiffies_timeout to guarantee minimum duration Imre Deak
2013-05-21 17:03 ` [PATCH 2/4] drm/i915: use msecs_to_jiffies_timeout instead of open coding the same Imre Deak
2013-05-21 17:20 ` Daniel Vetter
2013-05-21 18:00 ` Imre Deak [this message]
2013-05-21 18:20 ` Daniel Vetter
2013-05-21 17:03 ` [PATCH 3/4] drm/i915: avoid premature timeouts in __wait_seqno() Imre Deak
2013-05-21 17:03 ` [PATCH 4/4] drm/i915: avoid premature DP AUX timeouts Imre Deak
2013-05-22 7:48 ` [PATCH 1/4] drm/i915: add msecs_to_jiffies_timeout to guarantee minimum duration Jani Nikula
2013-05-22 9:46 ` Daniel Vetter
2013-05-22 9:57 ` Imre Deak
2013-05-22 11:51 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369159249.944.3.camel@ideak-mobl \
--to=imre.deak@intel.com \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox