From: ville.syrjala@linux.intel.com
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 0/4] drm/i915: Gen2/3 C3 wakeup stuff
Date: Tue, 25 Feb 2014 15:13:37 +0200 [thread overview]
Message-ID: <1393334021-31268-1-git-send-email-ville.syrjala@linux.intel.com> (raw)
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
I tried to fix the C3 vs. vblank interrupt issues reportd in [1], but
it looks like the AGPBUSY# stuff doesn't help there for some reason. I
guess either the board isn't wired correctly, or we're missing
something else. I doubt the BM wakup mechanism itself would be
broken since then I would expect the machine to lock up when someone
does DMA while in C3. IIRC I actually had that kind of an issue on
some old VIA chipset long ago.
Anyways, my 855gm actually supports C3, and on that machine the MI_STATE
AGPBUSY# stuff is effective. So I'm going to assume that gen3 behaviour
should match, and so I'm just sticking it all into .init_clock_gating()
for both gen2 and gen3.
I also found another gen3 C3 bit in i915_gem_load(). I think it would
be better to collect that into .init_clock_gating() as well. But I left
it also in i915_gem_load() for UMS.
[1] https://bugs.freedesktop.org/show_bug.cgi?id=30364
Ville Syrjälä (4):
drm/i915: Set AGPBUSY# bit in init_clock_gating
drm/i915: Flip the sense of AGPBUSY_DIS bit
drm/i915: Enable interrupt-based AGPBUSY# enable on 85x
drm/i915: Move the C3 LP write bit setup to gen3_init_clock_gating()
for KMS
drivers/gpu/drm/i915/i915_gem.c | 2 +-
drivers/gpu/drm/i915/i915_irq.c | 7 -------
drivers/gpu/drm/i915/i915_reg.h | 6 +++++-
drivers/gpu/drm/i915/intel_pm.c | 10 ++++++++++
4 files changed, 16 insertions(+), 9 deletions(-)
--
1.8.3.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next reply other threads:[~2014-02-25 13:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-25 13:13 ville.syrjala [this message]
2014-02-25 13:13 ` [PATCH 1/4] drm/i915: Set AGPBUSY# bit in init_clock_gating ville.syrjala
2014-02-25 13:13 ` [PATCH v2 2/4] drm/i915: Flip the sense of AGPBUSY_DIS bit ville.syrjala
2014-02-25 13:13 ` [PATCH 3/4] drm/i915: Enable interrupt-based AGPBUSY# enable on 85x ville.syrjala
2014-02-25 13:13 ` [PATCH 4/4] drm/i915: Move the C3 LP write bit setup to gen3_init_clock_gating() for KMS ville.syrjala
2014-05-28 8:19 ` [PATCH 0/4] drm/i915: Gen2/3 C3 wakeup stuff Chris Wilson
2014-05-28 9:46 ` Ville Syrjälä
2014-05-28 9:59 ` Chris Wilson
2014-05-28 12:51 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1393334021-31268-1-git-send-email-ville.syrjala@linux.intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).