From: naresh.kumar.kachhi@intel.com
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH v2 1/3] drm/i915: disable rings before HW status page setup
Date: Wed, 12 Mar 2014 16:39:40 +0530 [thread overview]
Message-ID: <1394622582-21762-2-git-send-email-naresh.kumar.kachhi@intel.com> (raw)
In-Reply-To: <1394622582-21762-1-git-send-email-naresh.kumar.kachhi@intel.com>
From: Naresh Kumar Kachhi <naresh.kumar.kachhi@intel.com>
Rings should be idle before issuing sync_flush
(in intel_ring_setup_status_page). This patch moves the ring
disabling before doing the HW status page setup.
Signed-off-by: Naresh Kumar Kachhi <naresh.kumar.kachhi@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/i915/intel_ringbuffer.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c
index 8590921..42b4001 100644
--- a/drivers/gpu/drm/i915/intel_ringbuffer.c
+++ b/drivers/gpu/drm/i915/intel_ringbuffer.c
@@ -440,16 +440,16 @@ static int init_ring_common(struct intel_ring_buffer *ring)
gen6_gt_force_wake_get(dev_priv, FORCEWAKE_ALL);
- if (I915_NEED_GFX_HWS(dev))
- intel_ring_setup_status_page(ring);
- else
- ring_setup_phys_status_page(ring);
-
/* Stop the ring if it's running. */
I915_WRITE_CTL(ring, 0);
I915_WRITE_HEAD(ring, 0);
ring->write_tail(ring, 0);
+ if (I915_NEED_GFX_HWS(dev))
+ intel_ring_setup_status_page(ring);
+ else
+ ring_setup_phys_status_page(ring);
+
head = I915_READ_HEAD(ring) & HEAD_ADDR;
/* G45 ring initialization fails to reset head to zero */
--
1.8.5.3
next prev parent reply other threads:[~2014-03-12 11:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-04 5:16 [PATCH] drm/i915: stop command parser before sync flush naresh.kumar.kachhi
2014-03-04 7:39 ` Chris Wilson
2014-03-12 6:50 ` [PATCH v1 0/2] disable rings " naresh.kumar.kachhi
2014-03-12 6:50 ` [PATCH v1 1/2] drm/i915: disable rings before HW status page setup naresh.kumar.kachhi
2014-03-12 6:50 ` [PATCH v1 2/2] drm/i915: warn if ring is active before sync flush naresh.kumar.kachhi
2014-03-12 8:06 ` [PATCH v1 0/2] disable rings " Chris Wilson
2014-03-12 8:12 ` Chris Wilson
2014-03-12 11:09 ` [PATCH v2 0/3] " naresh.kumar.kachhi
2014-03-12 11:09 ` naresh.kumar.kachhi [this message]
2014-03-12 11:09 ` [PATCH v2 2/3] drm/i915: wait for rings to become idle once disabled naresh.kumar.kachhi
2014-03-12 11:18 ` Chris Wilson
2014-03-12 11:09 ` [PATCH v2 3/3] drm/i915: warn if ring is active before sync flush naresh.kumar.kachhi
2014-03-12 11:28 ` [PATCH v2 0/3] disable rings " Chris Wilson
2014-03-12 15:07 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394622582-21762-2-git-send-email-naresh.kumar.kachhi@intel.com \
--to=naresh.kumar.kachhi@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox