Re: [PATCH v2 0/3] disable rings before sync flush

[Daniel Vetter <daniel@ffwll.ch>]

On Wed, Mar 12, 2014 at 11:28:03AM +0000, Chris Wilson wrote:
> On Wed, Mar 12, 2014 at 04:39:39PM +0530, naresh.kumar.kachhi@intel.com wrote:
> > From: Naresh Kumar Kachhi <naresh.kumar.kachhi@intel.com>
> > 
> > initial version: stop rings before sync flush
> > 
> > v1: address the comments from Chris Wilson on
> > http://www.spinics.net/lists/intel-gfx/msg41025.html.
> > Rather than adding stop and start ring, we are moving
> > ring disable before hw_status_page_setup (sync flush).
> > 
> > v2: Based on Chris's suggestion. Added one more patch to wait
> > until the rings become idle after disabling. In case of timeout
> > we log a message. 
> > 
> > Naresh Kumar Kachhi (3):
> >   drm/i915: disable rings before HW status page setup
> >   drm/i915: wait for rings to become idle once disabled
> >   drm/i915: warn if ring is active before sync flush
> > 
> >  drivers/gpu/drm/i915/i915_reg.h         |  2 ++
> >  drivers/gpu/drm/i915/intel_ringbuffer.c | 18 +++++++++++++-----
> >  drivers/gpu/drm/i915/intel_ringbuffer.h |  2 ++
> >  3 files changed, 17 insertions(+), 5 deletions(-)
> 
> With the minor changes in patch 2,
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> and the recommendation for stable@

All 3 merged with the request polish applied to the 2nd patch.

Thanks, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch