[IGT PATCH] intel_bios_reader: make edp block decode match kernel

[IGT PATCH] intel_bios_reader: make edp block decode match kernel

[Jani Nikula]

All the somewhat recent VBT specs and the kernel have different format
for the eDP block than what the tool decodes. What the tool does *may*
be correct for really old VBT, but I have no specs or other reference to
suppor this. Just do what the kernel does, that's what we're interested
in anyway.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 tools/intel_bios.h | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tools/intel_bios.h b/tools/intel_bios.h
index 128502039c66..832c580dd084 100644
--- a/tools/intel_bios.h
+++ b/tools/intel_bios.h
@@ -590,8 +590,11 @@ struct edp_link_params {
 struct bdb_edp {
 	struct edp_power_seq power_seqs[16];
 	uint32_t color_depth;
-	uint32_t sdrrs_msa_timing_delay;
 	struct edp_link_params link_params[16];
+	uint32_t sdrrs_msa_timing_delay;
+
+	uint16_t edp_s3d_feature;
+	uint16_t edp_t3_optimization;
 } __attribute__ ((packed));
 
 /*
-- 
1.9.1

Re: [IGT PATCH] intel_bios_reader: make edp block decode match kernel

[Damien Lespiau]

On Tue, May 06, 2014 at 02:27:23PM +0300, Jani Nikula wrote:
> All the somewhat recent VBT specs and the kernel have different format
> for the eDP block than what the tool decodes. What the tool does *may*
> be correct for really old VBT, but I have no specs or other reference to
> suppor this. Just do what the kernel does, that's what we're interested
> in anyway.
> 
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>

Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>

You may want to add checks on the VBT revision that introduce the
different parameters.

We're also missing the VswingPreEmphasisValue fields from rev. 173.

-- 
Damien

> ---
>  tools/intel_bios.h | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/intel_bios.h b/tools/intel_bios.h
> index 128502039c66..832c580dd084 100644
> --- a/tools/intel_bios.h
> +++ b/tools/intel_bios.h
> @@ -590,8 +590,11 @@ struct edp_link_params {
>  struct bdb_edp {
>  	struct edp_power_seq power_seqs[16];
>  	uint32_t color_depth;
> -	uint32_t sdrrs_msa_timing_delay;
>  	struct edp_link_params link_params[16];
> +	uint32_t sdrrs_msa_timing_delay;
> +
> +	uint16_t edp_s3d_feature;
> +	uint16_t edp_t3_optimization;
>  } __attribute__ ((packed));
>  
>  /*
> -- 
> 1.9.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [IGT PATCH] intel_bios_reader: make edp block decode match kernel

[Jani Nikula]

On Tue, 06 May 2014, Damien Lespiau <damien.lespiau@intel.com> wrote:
> On Tue, May 06, 2014 at 02:27:23PM +0300, Jani Nikula wrote:
>> All the somewhat recent VBT specs and the kernel have different format
>> for the eDP block than what the tool decodes. What the tool does *may*
>> be correct for really old VBT, but I have no specs or other reference to
>> suppor this. Just do what the kernel does, that's what we're interested
>> in anyway.
>> 
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
>
> You may want to add checks on the VBT revision that introduce the
> different parameters.

I *wanted* to. But the versions in the spec apparently get changed also
when that part about the spec actually hasn't changed. At least my
140-something spec had some of the same stuff that was indicated as
having been added at 150-something. :(

> We're also missing the VswingPreEmphasisValue fields from rev. 173.

Yup, need to be added later (when we actually start using those).

Ok to push?

BR,
Jani.

>
> -- 
> Damien
>
>> ---
>>  tools/intel_bios.h | 5 ++++-
>>  1 file changed, 4 insertions(+), 1 deletion(-)
>> 
>> diff --git a/tools/intel_bios.h b/tools/intel_bios.h
>> index 128502039c66..832c580dd084 100644
>> --- a/tools/intel_bios.h
>> +++ b/tools/intel_bios.h
>> @@ -590,8 +590,11 @@ struct edp_link_params {
>>  struct bdb_edp {
>>  	struct edp_power_seq power_seqs[16];
>>  	uint32_t color_depth;
>> -	uint32_t sdrrs_msa_timing_delay;
>>  	struct edp_link_params link_params[16];
>> +	uint32_t sdrrs_msa_timing_delay;
>> +
>> +	uint16_t edp_s3d_feature;
>> +	uint16_t edp_t3_optimization;
>>  } __attribute__ ((packed));
>>  
>>  /*
>> -- 
>> 1.9.1
>> 
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center

Re: [IGT PATCH] intel_bios_reader: make edp block decode match kernel

[Damien Lespiau]

On Tue, May 06, 2014 at 07:04:21PM +0300, Jani Nikula wrote:
> On Tue, 06 May 2014, Damien Lespiau <damien.lespiau@intel.com> wrote:
> > On Tue, May 06, 2014 at 02:27:23PM +0300, Jani Nikula wrote:
> >> All the somewhat recent VBT specs and the kernel have different format
> >> for the eDP block than what the tool decodes. What the tool does *may*
> >> be correct for really old VBT, but I have no specs or other reference to
> >> suppor this. Just do what the kernel does, that's what we're interested
> >> in anyway.
> >> 
> >> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> >
> > Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
> >
> > You may want to add checks on the VBT revision that introduce the
> > different parameters.
> 
> I *wanted* to. But the versions in the spec apparently get changed also
> when that part about the spec actually hasn't changed. At least my
> 140-something spec had some of the same stuff that was indicated as
> having been added at 150-something. :(
> 
> > We're also missing the VswingPreEmphasisValue fields from rev. 173.
> 
> Yup, need to be added later (when we actually start using those).
> 
> Ok to push?

Sure!

-- 
Damien