* [PATCH] drm/i915/bdw: Enable execlists by default where supported @ 2014-12-11 11:09 Thomas Daniel 2014-12-11 12:02 ` Jani Nikula 2014-12-11 12:48 ` [PATCH v2] " Thomas Daniel 0 siblings, 2 replies; 7+ messages in thread From: Thomas Daniel @ 2014-12-11 11:09 UTC (permalink / raw) To: intel-gfx Execlist support in the i915 driver is now considered good enough for the feature to be enabled by default on Gen8 and later and routinely tested. Adjusted i915 parameters structure initialization to reflect this and updated the comment in intel_sanitize_enable_execlists(). Issue: VIZ-2020 Signed-off-by: Thomas Daniel <thomas.daniel@intel.com> --- drivers/gpu/drm/i915/i915_params.c | 2 +- drivers/gpu/drm/i915/intel_lrc.c | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c index c91cb20..ad685d8 100644 --- a/drivers/gpu/drm/i915/i915_params.c +++ b/drivers/gpu/drm/i915/i915_params.c @@ -35,7 +35,7 @@ struct i915_params i915 __read_mostly = { .vbt_sdvo_panel_type = -1, .enable_rc6 = -1, .enable_fbc = -1, - .enable_execlists = 0, + .enable_execlists = -1, .enable_hangcheck = true, .enable_ppgtt = -1, .enable_psr = 0, diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c index 89b5577..4dc6d42 100644 --- a/drivers/gpu/drm/i915/intel_lrc.c +++ b/drivers/gpu/drm/i915/intel_lrc.c @@ -212,8 +212,7 @@ static int intel_lr_context_pin(struct intel_engine_cs *ring, * @enable_execlists: value of i915.enable_execlists module parameter. * * Only certain platforms support Execlists (the prerequisites being - * support for Logical Ring Contexts and Aliasing PPGTT or better), - * and only when enabled via module parameter. + * support for Logical Ring Contexts and Aliasing PPGTT or better). * * Return: 1 if Execlists is supported and has to be enabled. */ -- 1.7.9.5 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] drm/i915/bdw: Enable execlists by default where supported 2014-12-11 11:09 [PATCH] drm/i915/bdw: Enable execlists by default where supported Thomas Daniel @ 2014-12-11 12:02 ` Jani Nikula 2014-12-15 10:04 ` Daniel Vetter 2014-12-11 12:48 ` [PATCH v2] " Thomas Daniel 1 sibling, 1 reply; 7+ messages in thread From: Jani Nikula @ 2014-12-11 12:02 UTC (permalink / raw) To: Thomas Daniel, intel-gfx On Thu, 11 Dec 2014, Thomas Daniel <thomas.daniel@intel.com> wrote: > Execlist support in the i915 driver is now considered good enough for the > feature to be enabled by default on Gen8 and later and routinely tested. > Adjusted i915 parameters structure initialization to reflect this and updated > the comment in intel_sanitize_enable_execlists(). Please update the MODULE_PARM_DESC too. BR, Jani. > > Issue: VIZ-2020 > Signed-off-by: Thomas Daniel <thomas.daniel@intel.com> > --- > drivers/gpu/drm/i915/i915_params.c | 2 +- > drivers/gpu/drm/i915/intel_lrc.c | 3 +-- > 2 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c > index c91cb20..ad685d8 100644 > --- a/drivers/gpu/drm/i915/i915_params.c > +++ b/drivers/gpu/drm/i915/i915_params.c > @@ -35,7 +35,7 @@ struct i915_params i915 __read_mostly = { > .vbt_sdvo_panel_type = -1, > .enable_rc6 = -1, > .enable_fbc = -1, > - .enable_execlists = 0, > + .enable_execlists = -1, > .enable_hangcheck = true, > .enable_ppgtt = -1, > .enable_psr = 0, > diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c > index 89b5577..4dc6d42 100644 > --- a/drivers/gpu/drm/i915/intel_lrc.c > +++ b/drivers/gpu/drm/i915/intel_lrc.c > @@ -212,8 +212,7 @@ static int intel_lr_context_pin(struct intel_engine_cs *ring, > * @enable_execlists: value of i915.enable_execlists module parameter. > * > * Only certain platforms support Execlists (the prerequisites being > - * support for Logical Ring Contexts and Aliasing PPGTT or better), > - * and only when enabled via module parameter. > + * support for Logical Ring Contexts and Aliasing PPGTT or better). > * > * Return: 1 if Execlists is supported and has to be enabled. > */ > -- > 1.7.9.5 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drm/i915/bdw: Enable execlists by default where supported 2014-12-11 12:02 ` Jani Nikula @ 2014-12-15 10:04 ` Daniel Vetter 0 siblings, 0 replies; 7+ messages in thread From: Daniel Vetter @ 2014-12-15 10:04 UTC (permalink / raw) To: Jani Nikula; +Cc: intel-gfx On Thu, Dec 11, 2014 at 02:02:48PM +0200, Jani Nikula wrote: > On Thu, 11 Dec 2014, Thomas Daniel <thomas.daniel@intel.com> wrote: > > Execlist support in the i915 driver is now considered good enough for the > > feature to be enabled by default on Gen8 and later and routinely tested. > > Adjusted i915 parameters structure initialization to reflect this and updated > > the comment in intel_sanitize_enable_execlists(). > > Please update the MODULE_PARM_DESC too. Also we probably want to add a _debug annotation to this one given the hw team doesn't really like legacy submission all that much any more. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2] drm/i915/bdw: Enable execlists by default where supported 2014-12-11 11:09 [PATCH] drm/i915/bdw: Enable execlists by default where supported Thomas Daniel 2014-12-11 12:02 ` Jani Nikula @ 2014-12-11 12:48 ` Thomas Daniel 2014-12-11 21:51 ` shuang.he ` (2 more replies) 1 sibling, 3 replies; 7+ messages in thread From: Thomas Daniel @ 2014-12-11 12:48 UTC (permalink / raw) To: intel-gfx Execlist support in the i915 driver is now considered good enough for the feature to be enabled by default on Gen8 and later and routinely tested. Adjusted i915 parameters structure initialization to reflect this and updated the comment in intel_sanitize_enable_execlists(). v2: Update the MODULE_PARM_DESC too. Issue: VIZ-2020 Signed-off-by: Thomas Daniel <thomas.daniel@intel.com> --- drivers/gpu/drm/i915/i915_params.c | 4 ++-- drivers/gpu/drm/i915/intel_lrc.c | 3 +-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c index c91cb20..f6af6d4 100644 --- a/drivers/gpu/drm/i915/i915_params.c +++ b/drivers/gpu/drm/i915/i915_params.c @@ -35,7 +35,7 @@ struct i915_params i915 __read_mostly = { .vbt_sdvo_panel_type = -1, .enable_rc6 = -1, .enable_fbc = -1, - .enable_execlists = 0, + .enable_execlists = -1, .enable_hangcheck = true, .enable_ppgtt = -1, .enable_psr = 0, @@ -122,7 +122,7 @@ MODULE_PARM_DESC(enable_ppgtt, module_param_named(enable_execlists, i915.enable_execlists, int, 0400); MODULE_PARM_DESC(enable_execlists, "Override execlists usage. " - "(-1=auto, 0=disabled [default], 1=enabled)"); + "(-1=auto [default], 0=disabled, 1=enabled)"); module_param_named(enable_psr, i915.enable_psr, int, 0600); MODULE_PARM_DESC(enable_psr, "Enable PSR (default: false)"); diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c index 89b5577..4dc6d42 100644 --- a/drivers/gpu/drm/i915/intel_lrc.c +++ b/drivers/gpu/drm/i915/intel_lrc.c @@ -212,8 +212,7 @@ static int intel_lr_context_pin(struct intel_engine_cs *ring, * @enable_execlists: value of i915.enable_execlists module parameter. * * Only certain platforms support Execlists (the prerequisites being - * support for Logical Ring Contexts and Aliasing PPGTT or better), - * and only when enabled via module parameter. + * support for Logical Ring Contexts and Aliasing PPGTT or better). * * Return: 1 if Execlists is supported and has to be enabled. */ -- 1.7.9.5 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2] drm/i915/bdw: Enable execlists by default where supported 2014-12-11 12:48 ` [PATCH v2] " Thomas Daniel @ 2014-12-11 21:51 ` shuang.he 2014-12-15 10:06 ` Daniel Vetter 2014-12-15 10:07 ` Daniel Vetter 2 siblings, 0 replies; 7+ messages in thread From: shuang.he @ 2014-12-11 21:51 UTC (permalink / raw) To: shuang.he, intel-gfx, thomas.daniel Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang.he@intel.com) -------------------------------------Summary------------------------------------- Platform Delta drm-intel-nightly Series Applied PNV 364/364 364/364 ILK +1 364/366 365/366 SNB 448/450 448/450 IVB 497/498 497/498 BYT 289/289 289/289 HSW -1 563/564 562/564 BDW 417/417 417/417 -------------------------------------Detailed------------------------------------- Platform Test drm-intel-nightly Series Applied ILK igt_kms_flip_wf_vblank-ts-check DMESG_WARN(7, M26)PASS(25, M26M37) PASS(1, M37) *HSW igt_pm_rpm_dpms-mode-unset-non-lpsp PASS(3, M40) DMESG_WARN(1, M40) Note: You need to pay more attention to line start with '*' _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] drm/i915/bdw: Enable execlists by default where supported 2014-12-11 12:48 ` [PATCH v2] " Thomas Daniel 2014-12-11 21:51 ` shuang.he @ 2014-12-15 10:06 ` Daniel Vetter 2014-12-15 10:07 ` Daniel Vetter 2 siblings, 0 replies; 7+ messages in thread From: Daniel Vetter @ 2014-12-15 10:06 UTC (permalink / raw) To: Thomas Daniel; +Cc: intel-gfx On Thu, Dec 11, 2014 at 12:48:35PM +0000, Thomas Daniel wrote: > Execlist support in the i915 driver is now considered good enough for the > feature to be enabled by default on Gen8 and later and routinely tested. > Adjusted i915 parameters structure initialization to reflect this and updated > the comment in intel_sanitize_enable_execlists(). > > v2: Update the MODULE_PARM_DESC too. MO is to mention the reviewer for each change and add them to the cc: list. Not too important for something simple like this, but a good habit. > > Issue: VIZ-2020 > Signed-off-by: Thomas Daniel <thomas.daniel@intel.com> Queued for -next, thanks for the patch. -Daniel > --- > drivers/gpu/drm/i915/i915_params.c | 4 ++-- > drivers/gpu/drm/i915/intel_lrc.c | 3 +-- > 2 files changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c > index c91cb20..f6af6d4 100644 > --- a/drivers/gpu/drm/i915/i915_params.c > +++ b/drivers/gpu/drm/i915/i915_params.c > @@ -35,7 +35,7 @@ struct i915_params i915 __read_mostly = { > .vbt_sdvo_panel_type = -1, > .enable_rc6 = -1, > .enable_fbc = -1, > - .enable_execlists = 0, > + .enable_execlists = -1, > .enable_hangcheck = true, > .enable_ppgtt = -1, > .enable_psr = 0, > @@ -122,7 +122,7 @@ MODULE_PARM_DESC(enable_ppgtt, > module_param_named(enable_execlists, i915.enable_execlists, int, 0400); > MODULE_PARM_DESC(enable_execlists, > "Override execlists usage. " > - "(-1=auto, 0=disabled [default], 1=enabled)"); > + "(-1=auto [default], 0=disabled, 1=enabled)"); > > module_param_named(enable_psr, i915.enable_psr, int, 0600); > MODULE_PARM_DESC(enable_psr, "Enable PSR (default: false)"); > diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c > index 89b5577..4dc6d42 100644 > --- a/drivers/gpu/drm/i915/intel_lrc.c > +++ b/drivers/gpu/drm/i915/intel_lrc.c > @@ -212,8 +212,7 @@ static int intel_lr_context_pin(struct intel_engine_cs *ring, > * @enable_execlists: value of i915.enable_execlists module parameter. > * > * Only certain platforms support Execlists (the prerequisites being > - * support for Logical Ring Contexts and Aliasing PPGTT or better), > - * and only when enabled via module parameter. > + * support for Logical Ring Contexts and Aliasing PPGTT or better). > * > * Return: 1 if Execlists is supported and has to be enabled. > */ > -- > 1.7.9.5 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] drm/i915/bdw: Enable execlists by default where supported 2014-12-11 12:48 ` [PATCH v2] " Thomas Daniel 2014-12-11 21:51 ` shuang.he 2014-12-15 10:06 ` Daniel Vetter @ 2014-12-15 10:07 ` Daniel Vetter 2 siblings, 0 replies; 7+ messages in thread From: Daniel Vetter @ 2014-12-15 10:07 UTC (permalink / raw) To: Thomas Daniel; +Cc: intel-gfx On Thu, Dec 11, 2014 at 12:48:35PM +0000, Thomas Daniel wrote: > Execlist support in the i915 driver is now considered good enough for the > feature to be enabled by default on Gen8 and later and routinely tested. > Adjusted i915 parameters structure initialization to reflect this and updated > the comment in intel_sanitize_enable_execlists(). Oh and I added a note that we still have a bit of work to do before the 3.20 cutoff. But enabling earlier is beneficial for testing and the 3.20 cycle just started for drm/i915 so here we go. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-12-15 10:07 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-12-11 11:09 [PATCH] drm/i915/bdw: Enable execlists by default where supported Thomas Daniel 2014-12-11 12:02 ` Jani Nikula 2014-12-15 10:04 ` Daniel Vetter 2014-12-11 12:48 ` [PATCH v2] " Thomas Daniel 2014-12-11 21:51 ` shuang.he 2014-12-15 10:06 ` Daniel Vetter 2014-12-15 10:07 ` Daniel Vetter
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox