Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Paulo Zanoni <przanoni@gmail.com>
To: intel-gfx@lists.freedesktop.org
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: [PATCH 0/9] More simple FBC fixes
Date: Tue, 23 Dec 2014 10:35:36 -0200	[thread overview]
Message-ID: <1419338145-1912-1-git-send-email-przanoni@gmail.com> (raw)

From: Paulo Zanoni <paulo.r.zanoni@intel.com>

Hi

Since the previous FBC series is already entirely reviewed, it's time to submit
a few more FBC patches to the mailing list. These patches just fix some simple
bugs and annoyances: nothing really major. I tested them on my BDW and they pass
the tests I have.

In theory we could even think about maybe enabling FBC on HSW+ since I can't
think of any bugs remaining on these platforms. The biggest reason to prevent
that is that I still didn't upstream the FBC tests I wrote since I still didn't
integrate them to kms_fbc_crc - which I'm also running.

This doesn't mean FBC's TODO list is empty: there are still a lot of small
improvements to do, and one of them is to _not_ disable FBC during page flips.
I also didn't really do any power or performance tests yet: the focus is
completely on bugs.

Regarding the previous platforms, I think there could be some hope to support
FBC on ILK+, but I'm really only focused on HSW+, so I don't know if we're
missing some checks and restrictions. For the older platforms, I think that,
given all the conditions, the risk of enabling FBC and breaking these platforms
even more is probably not worth it.

Thanks,
Paulo

Paulo Zanoni (9):
  drm/i915: don't reallocate the compressed FB at every frame
  drm/i915: fix the FBC CFB size tracking
  drm/i915: don't increment the FBC threshold at fbc_enable
  drm/i915: don't free the CFB while FBC is enabled
  drm/i915: don't set the FBC plane select bits on HSW+
  drm/i915: add the FBC mutex
  drm/i915: don't alloc/free fbc_work at every update
  drm/i915: print FBC compression status on debugfs
  drm/i915: FBC only supports 16bpp and 32bpp

 drivers/gpu/drm/i915/i915_debugfs.c    |   5 +
 drivers/gpu/drm/i915/i915_drv.h        |   5 +-
 drivers/gpu/drm/i915/i915_gem_stolen.c |  16 ++--
 drivers/gpu/drm/i915/i915_reg.h        |   3 +
 drivers/gpu/drm/i915/intel_fbc.c       | 161 +++++++++++++++++++++------------
 5 files changed, 123 insertions(+), 67 deletions(-)

-- 
2.1.3

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

             reply	other threads:[~2014-12-23 12:36 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-23 12:35 Paulo Zanoni [this message]
2014-12-23 12:35 ` [PATCH 1/9] drm/i915: don't reallocate the compressed FB at every frame Paulo Zanoni
2014-12-23 12:35 ` [PATCH 2/9] drm/i915: fix the FBC CFB size tracking Paulo Zanoni
2014-12-25 10:16   ` Chris Wilson
2014-12-26 13:46     ` Paulo Zanoni
2014-12-26 13:53       ` Chris Wilson
2014-12-23 12:35 ` [PATCH 3/9] drm/i915: don't increment the FBC threshold at fbc_enable Paulo Zanoni
2014-12-23 12:35 ` [PATCH 4/9] drm/i915: don't free the CFB while FBC is enabled Paulo Zanoni
2014-12-25 10:20   ` Chris Wilson
2014-12-26 13:46     ` Paulo Zanoni
2014-12-26 13:55       ` Chris Wilson
2014-12-23 12:35 ` [PATCH 5/9] drm/i915: don't set the FBC plane select bits on HSW+ Paulo Zanoni
2015-01-05 15:40   ` Daniel Vetter
2014-12-23 12:35 ` [PATCH 6/9] drm/i915: add the FBC mutex Paulo Zanoni
2014-12-25 10:25   ` Chris Wilson
2014-12-26 13:46     ` Paulo Zanoni
2014-12-23 12:35 ` [PATCH 7/9] drm/i915: don't alloc/free fbc_work at every update Paulo Zanoni
2014-12-25 10:33   ` Chris Wilson
2014-12-26 13:49     ` Paulo Zanoni
2014-12-23 12:35 ` [PATCH 8/9] drm/i915: print FBC compression status on debugfs Paulo Zanoni
2014-12-23 12:35 ` [PATCH 9/9] drm/i915: FBC only supports 16bpp and 32bpp Paulo Zanoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1419338145-1912-1-git-send-email-przanoni@gmail.com \
    --to=przanoni@gmail.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=paulo.r.zanoni@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox