* [PATCH] drm/i915: s/DPPL/DPLL/ for SKL DPLLs
@ 2016-05-11 19:04 ville.syrjala
2016-05-11 19:55 ` ✗ Ro.CI.BAT: failure for " Patchwork
2016-05-12 7:15 ` [PATCH] " Ander Conselvan De Oliveira
0 siblings, 2 replies; 5+ messages in thread
From: ville.syrjala @ 2016-05-11 19:04 UTC (permalink / raw)
To: intel-gfx; +Cc: Ander Conselvan de Oliveira
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
SKL DPLLs shouldn't be called DPPLs.
Cc: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
Fixes: 2edd6443e3d0 ("drm/i915: Use a table to initilize shared dplls")
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/intel_dpll_mgr.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_dpll_mgr.c b/drivers/gpu/drm/i915/intel_dpll_mgr.c
index 639bf0209c15..3ac705936b04 100644
--- a/drivers/gpu/drm/i915/intel_dpll_mgr.c
+++ b/drivers/gpu/drm/i915/intel_dpll_mgr.c
@@ -1702,9 +1702,9 @@ static const struct intel_dpll_mgr hsw_pll_mgr = {
static const struct dpll_info skl_plls[] = {
{ "DPLL 0", DPLL_ID_SKL_DPLL0, &skl_ddi_dpll0_funcs, INTEL_DPLL_ALWAYS_ON },
- { "DPPL 1", DPLL_ID_SKL_DPLL1, &skl_ddi_pll_funcs, 0 },
- { "DPPL 2", DPLL_ID_SKL_DPLL2, &skl_ddi_pll_funcs, 0 },
- { "DPPL 3", DPLL_ID_SKL_DPLL3, &skl_ddi_pll_funcs, 0 },
+ { "DPLL 1", DPLL_ID_SKL_DPLL1, &skl_ddi_pll_funcs, 0 },
+ { "DPLL 2", DPLL_ID_SKL_DPLL2, &skl_ddi_pll_funcs, 0 },
+ { "DPLL 3", DPLL_ID_SKL_DPLL3, &skl_ddi_pll_funcs, 0 },
{ NULL, -1, NULL, },
};
--
2.7.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread* ✗ Ro.CI.BAT: failure for drm/i915: s/DPPL/DPLL/ for SKL DPLLs
2016-05-11 19:04 [PATCH] drm/i915: s/DPPL/DPLL/ for SKL DPLLs ville.syrjala
@ 2016-05-11 19:55 ` Patchwork
2016-05-12 11:24 ` Ville Syrjälä
2016-05-12 7:15 ` [PATCH] " Ander Conselvan De Oliveira
1 sibling, 1 reply; 5+ messages in thread
From: Patchwork @ 2016-05-11 19:55 UTC (permalink / raw)
To: ville.syrjala; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: s/DPPL/DPLL/ for SKL DPLLs
URL : https://patchwork.freedesktop.org/series/7034/
State : failure
== Summary ==
Series 7034v1 drm/i915: s/DPPL/DPLL/ for SKL DPLLs
http://patchwork.freedesktop.org/api/1.0/series/7034/revisions/1/mbox
Test drv_hangman:
Subgroup error-state-basic:
pass -> FAIL (ro-ilk1-i5-650)
Test kms_flip:
Subgroup basic-flip-vs-wf_vblank:
fail -> PASS (ro-ivb2-i7-3770)
Test kms_pipe_crc_basic:
Subgroup nonblocking-crc-pipe-a-frame-sequence:
fail -> PASS (ro-snb-i7-2620M)
ro-bdw-i5-5250u total:219 pass:181 dwarn:0 dfail:0 fail:0 skip:38
ro-bdw-i7-5557U total:219 pass:205 dwarn:1 dfail:0 fail:0 skip:13
ro-bdw-i7-5600u total:219 pass:187 dwarn:0 dfail:0 fail:0 skip:32
ro-bsw-n3050 total:219 pass:175 dwarn:0 dfail:0 fail:2 skip:42
ro-byt-n2820 total:218 pass:174 dwarn:0 dfail:0 fail:3 skip:41
ro-hsw-i3-4010u total:218 pass:193 dwarn:0 dfail:0 fail:0 skip:25
ro-hsw-i7-4770r total:219 pass:194 dwarn:0 dfail:0 fail:0 skip:25
ro-ilk-i7-620lm total:219 pass:151 dwarn:0 dfail:0 fail:1 skip:67
ro-ilk1-i5-650 total:214 pass:151 dwarn:0 dfail:0 fail:2 skip:61
ro-ivb-i7-3770 total:219 pass:183 dwarn:0 dfail:0 fail:0 skip:36
ro-ivb2-i7-3770 total:219 pass:187 dwarn:0 dfail:0 fail:0 skip:32
ro-skl-i7-6700hq total:214 pass:190 dwarn:0 dfail:0 fail:0 skip:24
ro-snb-i7-2620M total:219 pass:177 dwarn:0 dfail:0 fail:1 skip:41
Results at /archive/results/CI_IGT_test/RO_Patchwork_855/
576b6d9 drm-intel-nightly: 2016y-05m-11d-17h-10m-57s UTC integration manifest
64bed24 drm/i915: s/DPPL/DPLL/ for SKL DPLLs
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: ✗ Ro.CI.BAT: failure for drm/i915: s/DPPL/DPLL/ for SKL DPLLs
2016-05-11 19:55 ` ✗ Ro.CI.BAT: failure for " Patchwork
@ 2016-05-12 11:24 ` Ville Syrjälä
0 siblings, 0 replies; 5+ messages in thread
From: Ville Syrjälä @ 2016-05-12 11:24 UTC (permalink / raw)
To: intel-gfx
On Wed, May 11, 2016 at 07:55:37PM -0000, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915: s/DPPL/DPLL/ for SKL DPLLs
> URL : https://patchwork.freedesktop.org/series/7034/
> State : failure
>
> == Summary ==
>
> Series 7034v1 drm/i915: s/DPPL/DPLL/ for SKL DPLLs
> http://patchwork.freedesktop.org/api/1.0/series/7034/revisions/1/mbox
>
> Test drv_hangman:
> Subgroup error-state-basic:
> pass -> FAIL (ro-ilk1-i5-650)
(drv_hangman:6088) CRITICAL: contents of i915_error_state: 'no error state collected' (expected not 'no error state collected'
Happens on that machine a lot. Bug filed:
https://bugs.freedesktop.org/show_bug.cgi?id=95364
> Test kms_flip:
> Subgroup basic-flip-vs-wf_vblank:
> fail -> PASS (ro-ivb2-i7-3770)
> Test kms_pipe_crc_basic:
> Subgroup nonblocking-crc-pipe-a-frame-sequence:
> fail -> PASS (ro-snb-i7-2620M)
>
> ro-bdw-i5-5250u total:219 pass:181 dwarn:0 dfail:0 fail:0 skip:38
> ro-bdw-i7-5557U total:219 pass:205 dwarn:1 dfail:0 fail:0 skip:13
> ro-bdw-i7-5600u total:219 pass:187 dwarn:0 dfail:0 fail:0 skip:32
> ro-bsw-n3050 total:219 pass:175 dwarn:0 dfail:0 fail:2 skip:42
> ro-byt-n2820 total:218 pass:174 dwarn:0 dfail:0 fail:3 skip:41
> ro-hsw-i3-4010u total:218 pass:193 dwarn:0 dfail:0 fail:0 skip:25
> ro-hsw-i7-4770r total:219 pass:194 dwarn:0 dfail:0 fail:0 skip:25
> ro-ilk-i7-620lm total:219 pass:151 dwarn:0 dfail:0 fail:1 skip:67
> ro-ilk1-i5-650 total:214 pass:151 dwarn:0 dfail:0 fail:2 skip:61
> ro-ivb-i7-3770 total:219 pass:183 dwarn:0 dfail:0 fail:0 skip:36
> ro-ivb2-i7-3770 total:219 pass:187 dwarn:0 dfail:0 fail:0 skip:32
> ro-skl-i7-6700hq total:214 pass:190 dwarn:0 dfail:0 fail:0 skip:24
> ro-snb-i7-2620M total:219 pass:177 dwarn:0 dfail:0 fail:1 skip:41
>
> Results at /archive/results/CI_IGT_test/RO_Patchwork_855/
>
> 576b6d9 drm-intel-nightly: 2016y-05m-11d-17h-10m-57s UTC integration manifest
> 64bed24 drm/i915: s/DPPL/DPLL/ for SKL DPLLs
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915: s/DPPL/DPLL/ for SKL DPLLs
2016-05-11 19:04 [PATCH] drm/i915: s/DPPL/DPLL/ for SKL DPLLs ville.syrjala
2016-05-11 19:55 ` ✗ Ro.CI.BAT: failure for " Patchwork
@ 2016-05-12 7:15 ` Ander Conselvan De Oliveira
2016-05-12 11:32 ` Ville Syrjälä
1 sibling, 1 reply; 5+ messages in thread
From: Ander Conselvan De Oliveira @ 2016-05-12 7:15 UTC (permalink / raw)
To: ville.syrjala, intel-gfx
On Wed, 2016-05-11 at 22:04 +0300, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> SKL DPLLs shouldn't be called DPPLs.
I really didn't notice that typo. Thanks for fixing.
Reviewed-by: Ander Conselvan de Oliveira <conselvan2@gmail.com>
>
> Cc: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
> Fixes: 2edd6443e3d0 ("drm/i915: Use a table to initilize shared dplls")
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_dpll_mgr.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dpll_mgr.c
> b/drivers/gpu/drm/i915/intel_dpll_mgr.c
> index 639bf0209c15..3ac705936b04 100644
> --- a/drivers/gpu/drm/i915/intel_dpll_mgr.c
> +++ b/drivers/gpu/drm/i915/intel_dpll_mgr.c
> @@ -1702,9 +1702,9 @@ static const struct intel_dpll_mgr hsw_pll_mgr = {
>
> static const struct dpll_info skl_plls[] = {
> { "DPLL 0", DPLL_ID_SKL_DPLL0, &skl_ddi_dpll0_funcs,
> INTEL_DPLL_ALWAYS_ON },
> - { "DPPL 1", DPLL_ID_SKL_DPLL1, &skl_ddi_pll_funcs, 0 },
> - { "DPPL 2", DPLL_ID_SKL_DPLL2, &skl_ddi_pll_funcs, 0 },
> - { "DPPL 3", DPLL_ID_SKL_DPLL3, &skl_ddi_pll_funcs, 0 },
> + { "DPLL 1", DPLL_ID_SKL_DPLL1, &skl_ddi_pll_funcs, 0 },
> + { "DPLL 2", DPLL_ID_SKL_DPLL2, &skl_ddi_pll_funcs, 0 },
> + { "DPLL 3", DPLL_ID_SKL_DPLL3, &skl_ddi_pll_funcs, 0 },
> { NULL, -1, NULL, },
> };
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/i915: s/DPPL/DPLL/ for SKL DPLLs
2016-05-12 7:15 ` [PATCH] " Ander Conselvan De Oliveira
@ 2016-05-12 11:32 ` Ville Syrjälä
0 siblings, 0 replies; 5+ messages in thread
From: Ville Syrjälä @ 2016-05-12 11:32 UTC (permalink / raw)
To: Ander Conselvan De Oliveira; +Cc: intel-gfx
On Thu, May 12, 2016 at 10:15:45AM +0300, Ander Conselvan De Oliveira wrote:
> On Wed, 2016-05-11 at 22:04 +0300, ville.syrjala@linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > SKL DPLLs shouldn't be called DPPLs.
>
> I really didn't notice that typo. Thanks for fixing.
>
> Reviewed-by: Ander Conselvan de Oliveira <conselvan2@gmail.com>
Thanks. Pushed to dinq.
>
> >
> > Cc: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
> > Fixes: 2edd6443e3d0 ("drm/i915: Use a table to initilize shared dplls")
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> > drivers/gpu/drm/i915/intel_dpll_mgr.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_dpll_mgr.c
> > b/drivers/gpu/drm/i915/intel_dpll_mgr.c
> > index 639bf0209c15..3ac705936b04 100644
> > --- a/drivers/gpu/drm/i915/intel_dpll_mgr.c
> > +++ b/drivers/gpu/drm/i915/intel_dpll_mgr.c
> > @@ -1702,9 +1702,9 @@ static const struct intel_dpll_mgr hsw_pll_mgr = {
> >
> > static const struct dpll_info skl_plls[] = {
> > { "DPLL 0", DPLL_ID_SKL_DPLL0, &skl_ddi_dpll0_funcs,
> > INTEL_DPLL_ALWAYS_ON },
> > - { "DPPL 1", DPLL_ID_SKL_DPLL1, &skl_ddi_pll_funcs, 0 },
> > - { "DPPL 2", DPLL_ID_SKL_DPLL2, &skl_ddi_pll_funcs, 0 },
> > - { "DPPL 3", DPLL_ID_SKL_DPLL3, &skl_ddi_pll_funcs, 0 },
> > + { "DPLL 1", DPLL_ID_SKL_DPLL1, &skl_ddi_pll_funcs, 0 },
> > + { "DPLL 2", DPLL_ID_SKL_DPLL2, &skl_ddi_pll_funcs, 0 },
> > + { "DPLL 3", DPLL_ID_SKL_DPLL3, &skl_ddi_pll_funcs, 0 },
> > { NULL, -1, NULL, },
> > };
> >
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-05-12 11:32 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-11 19:04 [PATCH] drm/i915: s/DPPL/DPLL/ for SKL DPLLs ville.syrjala
2016-05-11 19:55 ` ✗ Ro.CI.BAT: failure for " Patchwork
2016-05-12 11:24 ` Ville Syrjälä
2016-05-12 7:15 ` [PATCH] " Ander Conselvan De Oliveira
2016-05-12 11:32 ` Ville Syrjälä
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox