From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: Mika Kuoppala <mika.kuoppala@intel.com>
Subject: Re: [PATCH v3 05/10] drm/i915: No need to wait for idle on L3 remap
Date: Thu, 26 May 2016 15:15:30 +0300 [thread overview]
Message-ID: <1464264930.15523.9.camel@linux.intel.com> (raw)
In-Reply-To: <1464252760-23902-6-git-send-email-chris@chris-wilson.co.uk>
On to, 2016-05-26 at 09:52 +0100, Chris Wilson wrote:
> As the L3 remapping is applied before the next execution, there is no
> need to wait until all previous uses are idle, the application will not
> occur any sooner.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> ---
> drivers/gpu/drm/i915/i915_sysfs.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_sysfs.c b/drivers/gpu/drm/i915/i915_sysfs.c
> index 02507bfc8def..a6e90fe05a1e 100644
> --- a/drivers/gpu/drm/i915/i915_sysfs.c
> +++ b/drivers/gpu/drm/i915/i915_sysfs.c
> @@ -227,13 +227,6 @@ i915_l3_write(struct file *filp, struct kobject *kobj,
> }
> }
>
> - ret = i915_gpu_idle(drm_dev);
> - if (ret) {
> - kfree(temp);
> - mutex_unlock(&drm_dev->struct_mutex);
> - return ret;
> - }
> -
> /* TODO: Ideally we really want a GPU reset here to make sure errors
> * aren't propagated. Since I cannot find a stable way to reset the GPU
> * at this point it is left as a TODO.
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-05-26 12:15 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-26 8:52 Bug 95634, take 2 Chris Wilson
2016-05-26 8:52 ` [PATCH v3 01/10] drm/i915: Skip idling an idle engine Chris Wilson
2016-05-26 8:52 ` [PATCH v3 02/10] drm/i915: Move legacy kernel context pinning to intel_ringbuffer.c Chris Wilson
2016-05-26 12:04 ` Mika Kuoppala
2016-05-26 12:27 ` Chris Wilson
2016-05-26 8:52 ` [PATCH v3 03/10] drm/i915: Treat kernel context as initialised Chris Wilson
2016-05-26 11:51 ` Chris Wilson
2016-05-26 12:34 ` Chris Wilson
2016-05-26 8:52 ` [PATCH v3 04/10] drm/i915: Mark all default contexts as uninitialised after context loss Chris Wilson
2016-05-26 8:52 ` [PATCH v3 05/10] drm/i915: No need to wait for idle on L3 remap Chris Wilson
2016-05-26 12:06 ` Mika Kuoppala
2016-05-26 12:15 ` Joonas Lahtinen [this message]
2016-05-26 8:52 ` [PATCH v3 06/10] drm/i915: Split idling from forcing context switch Chris Wilson
2016-05-26 11:39 ` Joonas Lahtinen
2016-05-26 8:52 ` [PATCH v3 07/10] drm/i915: Only switch to default context when evicting from GGTT Chris Wilson
2016-05-26 11:33 ` Joonas Lahtinen
2016-05-26 8:52 ` [PATCH v3 08/10] drm/i915: Preserve current RPS frequency Chris Wilson
2016-05-26 8:52 ` [PATCH v3 09/10] drm/i915: Remove superfluous powersave work flushing Chris Wilson
2016-05-26 11:45 ` Ville Syrjälä
2016-05-26 11:58 ` Chris Wilson
2016-05-26 12:35 ` [PATCH] drm: Register the debugfs interfaces after loading the driver Chris Wilson
2016-05-26 13:06 ` Chris Wilson
2016-05-27 6:47 ` Daniel Vetter
2016-05-27 7:44 ` Chris Wilson
2016-05-26 13:17 ` [PATCH] drm/i915: Register debugfs interface last Chris Wilson
2016-05-26 14:30 ` Ville Syrjälä
2016-05-26 8:52 ` [PATCH v3 10/10] drm/i915: Defer enabling rc6 til after we submit the first batch/context Chris Wilson
2016-05-26 9:24 ` ✗ Ro.CI.BAT: failure for series starting with [v3,01/10] drm/i915: Skip idling an idle engine Patchwork
2016-05-26 13:14 ` ✗ Ro.CI.BAT: failure for series starting with [v3,01/10] drm/i915: Skip idling an idle engine (rev2) Patchwork
2016-05-26 13:53 ` ✗ Ro.CI.BAT: warning for series starting with [v3,01/10] drm/i915: Skip idling an idle engine (rev3) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1464264930.15523.9.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mika.kuoppala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox