public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>,
	intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	ville.syrjala@linux.intel.com
Subject: Re: [PATCH] drm: Register the debugfs interfaces after loading the driver
Date: Fri, 27 May 2016 08:47:48 +0200	[thread overview]
Message-ID: <20160527064748.GV27098@phenom.ffwll.local> (raw)
In-Reply-To: <20160526130613.GD26684@nuc-i3427.alporthouse.com>

On Thu, May 26, 2016 at 02:06:13PM +0100, Chris Wilson wrote:
> On Thu, May 26, 2016 at 01:35:18PM +0100, Chris Wilson wrote:
> > In order to give the driver the chance to initialise the data structures
> > that will be exposed through debugfs, perform driver->load() before
> > registering the debugfs entries. (Otherwise it may be possible for
> > userspace to cause an oops through the debugfs interfaces.) As the
> > driver load is now before debugfs registration, make the registration
> > non-fatal (as it simply prevents us exposing an optional debug facility
> > and not hard ABI).
> 
> The alternative here would be for i915.ko to stop registering a
> driver->debugfs_init and do it as part of its registration phase (like
> sysfs).

I think the right fix would be to demidlayer i915 and stop using the
->load callback. Then we do have the right ordering, since debugfs setup
is done as part of the register phase.

It's just that for historical raisins load is called after the devnodes
are registered (because some dri1 drivers want to look at master/sarea
stuff iirc).
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2016-05-27  6:47 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-26  8:52 Bug 95634, take 2 Chris Wilson
2016-05-26  8:52 ` [PATCH v3 01/10] drm/i915: Skip idling an idle engine Chris Wilson
2016-05-26  8:52 ` [PATCH v3 02/10] drm/i915: Move legacy kernel context pinning to intel_ringbuffer.c Chris Wilson
2016-05-26 12:04   ` Mika Kuoppala
2016-05-26 12:27     ` Chris Wilson
2016-05-26  8:52 ` [PATCH v3 03/10] drm/i915: Treat kernel context as initialised Chris Wilson
2016-05-26 11:51   ` Chris Wilson
2016-05-26 12:34     ` Chris Wilson
2016-05-26  8:52 ` [PATCH v3 04/10] drm/i915: Mark all default contexts as uninitialised after context loss Chris Wilson
2016-05-26  8:52 ` [PATCH v3 05/10] drm/i915: No need to wait for idle on L3 remap Chris Wilson
2016-05-26 12:06   ` Mika Kuoppala
2016-05-26 12:15   ` Joonas Lahtinen
2016-05-26  8:52 ` [PATCH v3 06/10] drm/i915: Split idling from forcing context switch Chris Wilson
2016-05-26 11:39   ` Joonas Lahtinen
2016-05-26  8:52 ` [PATCH v3 07/10] drm/i915: Only switch to default context when evicting from GGTT Chris Wilson
2016-05-26 11:33   ` Joonas Lahtinen
2016-05-26  8:52 ` [PATCH v3 08/10] drm/i915: Preserve current RPS frequency Chris Wilson
2016-05-26  8:52 ` [PATCH v3 09/10] drm/i915: Remove superfluous powersave work flushing Chris Wilson
2016-05-26 11:45   ` Ville Syrjälä
2016-05-26 11:58     ` Chris Wilson
2016-05-26 12:35     ` [PATCH] drm: Register the debugfs interfaces after loading the driver Chris Wilson
2016-05-26 13:06       ` Chris Wilson
2016-05-27  6:47         ` Daniel Vetter [this message]
2016-05-27  7:44           ` Chris Wilson
2016-05-26 13:17     ` [PATCH] drm/i915: Register debugfs interface last Chris Wilson
2016-05-26 14:30       ` Ville Syrjälä
2016-05-26  8:52 ` [PATCH v3 10/10] drm/i915: Defer enabling rc6 til after we submit the first batch/context Chris Wilson
2016-05-26  9:24 ` ✗ Ro.CI.BAT: failure for series starting with [v3,01/10] drm/i915: Skip idling an idle engine Patchwork
2016-05-26 13:14 ` ✗ Ro.CI.BAT: failure for series starting with [v3,01/10] drm/i915: Skip idling an idle engine (rev2) Patchwork
2016-05-26 13:53 ` ✗ Ro.CI.BAT: warning for series starting with [v3,01/10] drm/i915: Skip idling an idle engine (rev3) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160527064748.GV27098@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=chris@chris-wilson.co.uk \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox