* [PATCH] drm/i915/glk: Fix DSI "*ERROR* ULPS is still active" messages
@ 2017-04-28 8:02 Ander Conselvan de Oliveira
2017-04-28 8:50 ` Chauhan, Madhav
2017-04-28 11:02 ` ✓ Fi.CI.BAT: success for " Patchwork
0 siblings, 2 replies; 6+ messages in thread
From: Ander Conselvan de Oliveira @ 2017-04-28 8:02 UTC (permalink / raw)
To: intel-gfx
Cc: Ander Conselvan de Oliveira, Deepak M, Jani Nikula,
drm-intel-fixes, Daniel Vetter
The sequence in glk_dsi_device_ready() enters ULPS then waits until it is
*not* active to then disable it. The correct sequence according to the
spec is to enter ULPS then wait until the GLK_ULPS_NOT_ACTIVE bit is
zero, i.e., ULPS is active, and then disable ULPS.
Fixing the codition gets rid of the following spurious error messages:
[drm:glk_dsi_device_ready [i915]] *ERROR* ULPS is still active
Fixes: 4644848369c0 ("drm/i915/glk: Add MIPIIO Enable/disable sequence")
Cc: Deepak M <m.deepak@intel.com>
Cc: Madhav Chauhan <madhav.chauhan@intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Daniel Vetter <daniel.vetter@intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Cc: <drm-intel-fixes@lists.freedesktop.org>
Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
---
drivers/gpu/drm/i915/intel_dsi.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_dsi.c b/drivers/gpu/drm/i915/intel_dsi.c
index 3ffe8b1..fc0ef49 100644
--- a/drivers/gpu/drm/i915/intel_dsi.c
+++ b/drivers/gpu/drm/i915/intel_dsi.c
@@ -410,11 +410,10 @@ static void glk_dsi_device_ready(struct intel_encoder *encoder)
val |= (ULPS_STATE_ENTER | DEVICE_READY);
I915_WRITE(MIPI_DEVICE_READY(port), val);
- /* Wait for ULPS Not active */
+ /* Wait for ULPS active */
if (intel_wait_for_register(dev_priv,
- MIPI_CTRL(port), GLK_ULPS_NOT_ACTIVE,
- GLK_ULPS_NOT_ACTIVE, 20))
- DRM_ERROR("ULPS is still active\n");
+ MIPI_CTRL(port), GLK_ULPS_NOT_ACTIVE, 0, 20))
+ DRM_ERROR("ULPS not active\n");
/* Exit ULPS */
val = I915_READ(MIPI_DEVICE_READY(port));
--
2.9.3
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915/glk: Fix DSI "*ERROR* ULPS is still active" messages
2017-04-28 8:02 [PATCH] drm/i915/glk: Fix DSI "*ERROR* ULPS is still active" messages Ander Conselvan de Oliveira
@ 2017-04-28 8:50 ` Chauhan, Madhav
2017-04-28 8:57 ` Ander Conselvan De Oliveira
2017-04-28 11:02 ` ✓ Fi.CI.BAT: success for " Patchwork
1 sibling, 1 reply; 6+ messages in thread
From: Chauhan, Madhav @ 2017-04-28 8:50 UTC (permalink / raw)
To: Conselvan De Oliveira, Ander, intel-gfx@lists.freedesktop.org
Cc: Deepak M, Nikula, Jani, drm-intel-fixes@lists.freedesktop.org,
Vetter, Daniel
> -----Original Message-----
> From: Conselvan De Oliveira, Ander
> Sent: Friday, April 28, 2017 1:32 PM
> To: intel-gfx@lists.freedesktop.org
> Cc: Conselvan De Oliveira, Ander <ander.conselvan.de.oliveira@intel.com>;
> Deepak M <m.deepak@intel.com>; Chauhan, Madhav
> <madhav.chauhan@intel.com>; Nikula, Jani <jani.nikula@intel.com>; Vetter,
> Daniel <daniel.vetter@intel.com>; Jani Nikula <jani.nikula@linux.intel.com>;
> drm-intel-fixes@lists.freedesktop.org
> Subject: [PATCH] drm/i915/glk: Fix DSI "*ERROR* ULPS is still active"
> messages
>
> The sequence in glk_dsi_device_ready() enters ULPS then waits until it is
> *not* active to then disable it. The correct sequence according to the spec is
> to enter ULPS then wait until the GLK_ULPS_NOT_ACTIVE bit is zero, i.e., ULPS
> is active, and then disable ULPS.
>
> Fixing the codition gets rid of the following spurious error messages:
Please correct the typo error to "condition", otherwise looks good.
Thanks for catching this.
>
> [drm:glk_dsi_device_ready [i915]] *ERROR* ULPS is still active
>
> Fixes: 4644848369c0 ("drm/i915/glk: Add MIPIIO Enable/disable sequence")
> Cc: Deepak M <m.deepak@intel.com>
> Cc: Madhav Chauhan <madhav.chauhan@intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: intel-gfx@lists.freedesktop.org
> Cc: <drm-intel-fixes@lists.freedesktop.org>
> Signed-off-by: Ander Conselvan de Oliveira
> <ander.conselvan.de.oliveira@intel.com>
> ---
> drivers/gpu/drm/i915/intel_dsi.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dsi.c
> b/drivers/gpu/drm/i915/intel_dsi.c
> index 3ffe8b1..fc0ef49 100644
> --- a/drivers/gpu/drm/i915/intel_dsi.c
> +++ b/drivers/gpu/drm/i915/intel_dsi.c
> @@ -410,11 +410,10 @@ static void glk_dsi_device_ready(struct
> intel_encoder *encoder)
> val |= (ULPS_STATE_ENTER | DEVICE_READY);
> I915_WRITE(MIPI_DEVICE_READY(port), val);
>
> - /* Wait for ULPS Not active */
> + /* Wait for ULPS active */
> if (intel_wait_for_register(dev_priv,
> - MIPI_CTRL(port), GLK_ULPS_NOT_ACTIVE,
> - GLK_ULPS_NOT_ACTIVE, 20))
> - DRM_ERROR("ULPS is still active\n");
> + MIPI_CTRL(port), GLK_ULPS_NOT_ACTIVE, 0,
> 20))
> + DRM_ERROR("ULPS not active\n");
>
> /* Exit ULPS */
> val = I915_READ(MIPI_DEVICE_READY(port));
> --
> 2.9.3
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915/glk: Fix DSI "*ERROR* ULPS is still active" messages
2017-04-28 8:50 ` Chauhan, Madhav
@ 2017-04-28 8:57 ` Ander Conselvan De Oliveira
2017-04-28 12:44 ` Chauhan, Madhav
0 siblings, 1 reply; 6+ messages in thread
From: Ander Conselvan De Oliveira @ 2017-04-28 8:57 UTC (permalink / raw)
To: Chauhan, Madhav, intel-gfx@lists.freedesktop.org
Cc: Deepak M, Nikula, Jani, drm-intel-fixes@lists.freedesktop.org,
Vetter, Daniel
On Fri, 2017-04-28 at 08:50 +0000, Chauhan, Madhav wrote:
> > -----Original Message-----
> > From: Conselvan De Oliveira, Ander
> > Sent: Friday, April 28, 2017 1:32 PM
> > To: intel-gfx@lists.freedesktop.org
> > Cc: Conselvan De Oliveira, Ander <ander.conselvan.de.oliveira@intel.com>;
> > Deepak M <m.deepak@intel.com>; Chauhan, Madhav
> > <madhav.chauhan@intel.com>; Nikula, Jani <jani.nikula@intel.com>; Vetter,
> > Daniel <daniel.vetter@intel.com>; Jani Nikula <jani.nikula@linux.intel.com>;
> > drm-intel-fixes@lists.freedesktop.org
> > Subject: [PATCH] drm/i915/glk: Fix DSI "*ERROR* ULPS is still active"
> > messages
> >
> > The sequence in glk_dsi_device_ready() enters ULPS then waits until it is
> > *not* active to then disable it. The correct sequence according to the spec is
> > to enter ULPS then wait until the GLK_ULPS_NOT_ACTIVE bit is zero, i.e., ULPS
> > is active, and then disable ULPS.
> >
> > Fixing the codition gets rid of the following spurious error messages:
>
> Please correct the typo error to "condition", otherwise looks good.
> Thanks for catching this.
If you upgrade the above statement to a Reviewed-by, I can fix the typo while
merging?
Ander
>
> >
> > [drm:glk_dsi_device_ready [i915]] *ERROR* ULPS is still active
> >
> > Fixes: 4644848369c0 ("drm/i915/glk: Add MIPIIO Enable/disable sequence")
> > Cc: Deepak M <m.deepak@intel.com>
> > Cc: Madhav Chauhan <madhav.chauhan@intel.com>
> > Cc: Jani Nikula <jani.nikula@intel.com>
> > Cc: Daniel Vetter <daniel.vetter@intel.com>
> > Cc: Jani Nikula <jani.nikula@linux.intel.com>
> > Cc: intel-gfx@lists.freedesktop.org
> > Cc: <drm-intel-fixes@lists.freedesktop.org>
> > Signed-off-by: Ander Conselvan de Oliveira
> > <ander.conselvan.de.oliveira@intel.com>
> > ---
> > drivers/gpu/drm/i915/intel_dsi.c | 7 +++----
> > 1 file changed, 3 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_dsi.c
> > b/drivers/gpu/drm/i915/intel_dsi.c
> > index 3ffe8b1..fc0ef49 100644
> > --- a/drivers/gpu/drm/i915/intel_dsi.c
> > +++ b/drivers/gpu/drm/i915/intel_dsi.c
> > @@ -410,11 +410,10 @@ static void glk_dsi_device_ready(struct
> > intel_encoder *encoder)
> > val |= (ULPS_STATE_ENTER | DEVICE_READY);
> > I915_WRITE(MIPI_DEVICE_READY(port), val);
> >
> > - /* Wait for ULPS Not active */
> > + /* Wait for ULPS active */
> > if (intel_wait_for_register(dev_priv,
> > - MIPI_CTRL(port), GLK_ULPS_NOT_ACTIVE,
> > - GLK_ULPS_NOT_ACTIVE, 20))
> > - DRM_ERROR("ULPS is still active\n");
> > + MIPI_CTRL(port), GLK_ULPS_NOT_ACTIVE, 0,
> > 20))
> > + DRM_ERROR("ULPS not active\n");
> >
> > /* Exit ULPS */
> > val = I915_READ(MIPI_DEVICE_READY(port));
> > --
> > 2.9.3
>
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915/glk: Fix DSI "*ERROR* ULPS is still active" messages
2017-04-28 8:02 [PATCH] drm/i915/glk: Fix DSI "*ERROR* ULPS is still active" messages Ander Conselvan de Oliveira
2017-04-28 8:50 ` Chauhan, Madhav
@ 2017-04-28 11:02 ` Patchwork
1 sibling, 0 replies; 6+ messages in thread
From: Patchwork @ 2017-04-28 11:02 UTC (permalink / raw)
To: Ander Conselvan de Oliveira; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/glk: Fix DSI "*ERROR* ULPS is still active" messages
URL : https://patchwork.freedesktop.org/series/23680/
State : success
== Summary ==
Series 23680v1 drm/i915/glk: Fix DSI "*ERROR* ULPS is still active" messages
https://patchwork.freedesktop.org/api/1.0/series/23680/revisions/1/mbox/
Test gem_exec_suspend:
Subgroup basic-s4-devices:
dmesg-warn -> PASS (fi-kbl-7560u) fdo#100125
Test kms_flip:
Subgroup basic-flip-vs-dpms:
pass -> DMESG-WARN (fi-byt-j1900) fdo#100652
fdo#100125 https://bugs.freedesktop.org/show_bug.cgi?id=100125
fdo#100652 https://bugs.freedesktop.org/show_bug.cgi?id=100652
fi-bdw-5557u total:278 pass:267 dwarn:0 dfail:0 fail:0 skip:11 time:427s
fi-bdw-gvtdvm total:278 pass:256 dwarn:8 dfail:0 fail:0 skip:14 time:429s
fi-bsw-n3050 total:278 pass:242 dwarn:0 dfail:0 fail:0 skip:36 time:579s
fi-bxt-j4205 total:278 pass:259 dwarn:0 dfail:0 fail:0 skip:19 time:509s
fi-bxt-t5700 total:278 pass:258 dwarn:0 dfail:0 fail:0 skip:20 time:542s
fi-byt-j1900 total:278 pass:253 dwarn:1 dfail:0 fail:0 skip:24 time:484s
fi-byt-n2820 total:278 pass:250 dwarn:0 dfail:0 fail:0 skip:28 time:478s
fi-hsw-4770 total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time:406s
fi-hsw-4770r total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time:402s
fi-ilk-650 total:278 pass:228 dwarn:0 dfail:0 fail:0 skip:50 time:416s
fi-ivb-3520m total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time:486s
fi-ivb-3770 total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time:471s
fi-kbl-7500u total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time:456s
fi-kbl-7560u total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time:563s
fi-skl-6260u total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time:455s
fi-skl-6700hq total:278 pass:261 dwarn:0 dfail:0 fail:0 skip:17 time:569s
fi-skl-6700k total:278 pass:256 dwarn:4 dfail:0 fail:0 skip:18 time:456s
fi-skl-6770hq total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time:493s
fi-skl-gvtdvm total:278 pass:265 dwarn:0 dfail:0 fail:0 skip:13 time:429s
fi-snb-2520m total:278 pass:250 dwarn:0 dfail:0 fail:0 skip:28 time:532s
fi-snb-2600 total:278 pass:249 dwarn:0 dfail:0 fail:0 skip:29 time:400s
86cc4197d2fa4c45b75bf54026765d27d86b84c8 drm-tip: 2017y-04m-28d-09h-14m-47s UTC integration manifest
b7f9ab5 drm/i915/glk: Fix DSI "*ERROR* ULPS is still active" messages
== Logs ==
For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_4575/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915/glk: Fix DSI "*ERROR* ULPS is still active" messages
2017-04-28 8:57 ` Ander Conselvan De Oliveira
@ 2017-04-28 12:44 ` Chauhan, Madhav
2017-04-28 14:16 ` Ander Conselvan De Oliveira
0 siblings, 1 reply; 6+ messages in thread
From: Chauhan, Madhav @ 2017-04-28 12:44 UTC (permalink / raw)
To: 'Ander Conselvan De Oliveira',
intel-gfx@lists.freedesktop.org
Cc: Deepak M, Nikula, Jani, drm-intel-fixes@lists.freedesktop.org,
Vetter, Daniel
> -----Original Message-----
> From: Ander Conselvan De Oliveira [mailto:conselvan2@gmail.com]
> Sent: Friday, April 28, 2017 2:28 PM
> To: Chauhan, Madhav <madhav.chauhan@intel.com>; intel-
> gfx@lists.freedesktop.org
> Cc: Deepak M <m.deepak@intel.com>; Nikula, Jani <jani.nikula@intel.com>;
> Vetter, Daniel <daniel.vetter@intel.com>; Jani Nikula
> <jani.nikula@linux.intel.com>; drm-intel-fixes@lists.freedesktop.org
> Subject: Re: [PATCH] drm/i915/glk: Fix DSI "*ERROR* ULPS is still active"
> messages
>
> On Fri, 2017-04-28 at 08:50 +0000, Chauhan, Madhav wrote:
> > > -----Original Message-----
> > > From: Conselvan De Oliveira, Ander
> > > Sent: Friday, April 28, 2017 1:32 PM
> > > To: intel-gfx@lists.freedesktop.org
> > > Cc: Conselvan De Oliveira, Ander
> > > <ander.conselvan.de.oliveira@intel.com>;
> > > Deepak M <m.deepak@intel.com>; Chauhan, Madhav
> > > <madhav.chauhan@intel.com>; Nikula, Jani <jani.nikula@intel.com>;
> > > Vetter, Daniel <daniel.vetter@intel.com>; Jani Nikula
> > > <jani.nikula@linux.intel.com>; drm-intel-fixes@lists.freedesktop.org
> > > Subject: [PATCH] drm/i915/glk: Fix DSI "*ERROR* ULPS is still active"
> > > messages
> > >
> > > The sequence in glk_dsi_device_ready() enters ULPS then waits until
> > > it is
> > > *not* active to then disable it. The correct sequence according to
> > > the spec is to enter ULPS then wait until the GLK_ULPS_NOT_ACTIVE
> > > bit is zero, i.e., ULPS is active, and then disable ULPS.
> > >
> > > Fixing the codition gets rid of the following spurious error messages:
> >
> > Please correct the typo error to "condition", otherwise looks good.
> > Thanks for catching this.
>
> If you upgrade the above statement to a Reviewed-by, I can fix the typo while
> merging?
>
> Ander
>
> >
> > >
> > > [drm:glk_dsi_device_ready [i915]] *ERROR* ULPS is still active
> > >
> > > Fixes: 4644848369c0 ("drm/i915/glk: Add MIPIIO Enable/disable
> > > sequence")
> > > Cc: Deepak M <m.deepak@intel.com>
> > > Cc: Madhav Chauhan <madhav.chauhan@intel.com>
> > > Cc: Jani Nikula <jani.nikula@intel.com>
> > > Cc: Daniel Vetter <daniel.vetter@intel.com>
> > > Cc: Jani Nikula <jani.nikula@linux.intel.com>
> > > Cc: intel-gfx@lists.freedesktop.org
> > > Cc: <drm-intel-fixes@lists.freedesktop.org>
> > > Signed-off-by: Ander Conselvan de Oliveira
> > > <ander.conselvan.de.oliveira@intel.com>
Reviewed-by: Madhav Chauhan <madhav.chauhan@intel.com>
> > > ---
> > > drivers/gpu/drm/i915/intel_dsi.c | 7 +++----
> > > 1 file changed, 3 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/intel_dsi.c
> > > b/drivers/gpu/drm/i915/intel_dsi.c
> > > index 3ffe8b1..fc0ef49 100644
> > > --- a/drivers/gpu/drm/i915/intel_dsi.c
> > > +++ b/drivers/gpu/drm/i915/intel_dsi.c
> > > @@ -410,11 +410,10 @@ static void glk_dsi_device_ready(struct
> > > intel_encoder *encoder)
> > > val |= (ULPS_STATE_ENTER | DEVICE_READY);
> > > I915_WRITE(MIPI_DEVICE_READY(port), val);
> > >
> > > - /* Wait for ULPS Not active */
> > > + /* Wait for ULPS active */
> > > if (intel_wait_for_register(dev_priv,
> > > - MIPI_CTRL(port), GLK_ULPS_NOT_ACTIVE,
> > > - GLK_ULPS_NOT_ACTIVE, 20))
> > > - DRM_ERROR("ULPS is still active\n");
> > > + MIPI_CTRL(port), GLK_ULPS_NOT_ACTIVE, 0,
> > > 20))
> > > + DRM_ERROR("ULPS not active\n");
> > >
> > > /* Exit ULPS */
> > > val = I915_READ(MIPI_DEVICE_READY(port));
> > > --
> > > 2.9.3
> >
> >
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915/glk: Fix DSI "*ERROR* ULPS is still active" messages
2017-04-28 12:44 ` Chauhan, Madhav
@ 2017-04-28 14:16 ` Ander Conselvan De Oliveira
0 siblings, 0 replies; 6+ messages in thread
From: Ander Conselvan De Oliveira @ 2017-04-28 14:16 UTC (permalink / raw)
To: Chauhan, Madhav, intel-gfx@lists.freedesktop.org
Cc: Deepak M, Nikula, Jani, drm-intel-fixes@lists.freedesktop.org,
Vetter, Daniel
On Fri, 2017-04-28 at 12:44 +0000, Chauhan, Madhav wrote:
> > -----Original Message-----
> > From: Ander Conselvan De Oliveira [mailto:conselvan2@gmail.com]
> > Sent: Friday, April 28, 2017 2:28 PM
> > To: Chauhan, Madhav <madhav.chauhan@intel.com>; intel-
> > gfx@lists.freedesktop.org
> > Cc: Deepak M <m.deepak@intel.com>; Nikula, Jani <jani.nikula@intel.com>;
> > Vetter, Daniel <daniel.vetter@intel.com>; Jani Nikula
> > <jani.nikula@linux.intel.com>; drm-intel-fixes@lists.freedesktop.org
> > Subject: Re: [PATCH] drm/i915/glk: Fix DSI "*ERROR* ULPS is still active"
> > messages
> >
> > On Fri, 2017-04-28 at 08:50 +0000, Chauhan, Madhav wrote:
> > > > -----Original Message-----
> > > > From: Conselvan De Oliveira, Ander
> > > > Sent: Friday, April 28, 2017 1:32 PM
> > > > To: intel-gfx@lists.freedesktop.org
> > > > Cc: Conselvan De Oliveira, Ander
> > > > <ander.conselvan.de.oliveira@intel.com>;
> > > > Deepak M <m.deepak@intel.com>; Chauhan, Madhav
> > > > <madhav.chauhan@intel.com>; Nikula, Jani <jani.nikula@intel.com>;
> > > > Vetter, Daniel <daniel.vetter@intel.com>; Jani Nikula
> > > > <jani.nikula@linux.intel.com>; drm-intel-fixes@lists.freedesktop.org
> > > > Subject: [PATCH] drm/i915/glk: Fix DSI "*ERROR* ULPS is still active"
> > > > messages
> > > >
> > > > The sequence in glk_dsi_device_ready() enters ULPS then waits until
> > > > it is
> > > > *not* active to then disable it. The correct sequence according to
> > > > the spec is to enter ULPS then wait until the GLK_ULPS_NOT_ACTIVE
> > > > bit is zero, i.e., ULPS is active, and then disable ULPS.
> > > >
> > > > Fixing the codition gets rid of the following spurious error messages:
> > >
> > > Please correct the typo error to "condition", otherwise looks good.
> > > Thanks for catching this.
> >
> > If you upgrade the above statement to a Reviewed-by, I can fix the typo while
> > merging?
> >
> > Ander
> >
> > >
> > > >
> > > > [drm:glk_dsi_device_ready [i915]] *ERROR* ULPS is still active
> > > >
> > > > Fixes: 4644848369c0 ("drm/i915/glk: Add MIPIIO Enable/disable
> > > > sequence")
> > > > Cc: Deepak M <m.deepak@intel.com>
> > > > Cc: Madhav Chauhan <madhav.chauhan@intel.com>
> > > > Cc: Jani Nikula <jani.nikula@intel.com>
> > > > Cc: Daniel Vetter <daniel.vetter@intel.com>
> > > > Cc: Jani Nikula <jani.nikula@linux.intel.com>
> > > > Cc: intel-gfx@lists.freedesktop.org
> > > > Cc: <drm-intel-fixes@lists.freedesktop.org>
> > > > Signed-off-by: Ander Conselvan de Oliveira
> > > > <ander.conselvan.de.oliveira@intel.com>
>
> Reviewed-by: Madhav Chauhan <madhav.chauhan@intel.com>
Pushed with the typo fixed. Thanks for reviewing.
Ander
>
>
> > > > ---
> > > > drivers/gpu/drm/i915/intel_dsi.c | 7 +++----
> > > > 1 file changed, 3 insertions(+), 4 deletions(-)
> > > >
> > > > diff --git a/drivers/gpu/drm/i915/intel_dsi.c
> > > > b/drivers/gpu/drm/i915/intel_dsi.c
> > > > index 3ffe8b1..fc0ef49 100644
> > > > --- a/drivers/gpu/drm/i915/intel_dsi.c
> > > > +++ b/drivers/gpu/drm/i915/intel_dsi.c
> > > > @@ -410,11 +410,10 @@ static void glk_dsi_device_ready(struct
> > > > intel_encoder *encoder)
> > > > val |= (ULPS_STATE_ENTER | DEVICE_READY);
> > > > I915_WRITE(MIPI_DEVICE_READY(port), val);
> > > >
> > > > - /* Wait for ULPS Not active */
> > > > + /* Wait for ULPS active */
> > > > if (intel_wait_for_register(dev_priv,
> > > > - MIPI_CTRL(port), GLK_ULPS_NOT_ACTIVE,
> > > > - GLK_ULPS_NOT_ACTIVE, 20))
> > > > - DRM_ERROR("ULPS is still active\n");
> > > > + MIPI_CTRL(port), GLK_ULPS_NOT_ACTIVE, 0,
> > > > 20))
> > > > + DRM_ERROR("ULPS not active\n");
> > > >
> > > > /* Exit ULPS */
> > > > val = I915_READ(MIPI_DEVICE_READY(port));
> > > > --
> > > > 2.9.3
> > >
> > >
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-04-28 14:16 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-28 8:02 [PATCH] drm/i915/glk: Fix DSI "*ERROR* ULPS is still active" messages Ander Conselvan de Oliveira
2017-04-28 8:50 ` Chauhan, Madhav
2017-04-28 8:57 ` Ander Conselvan De Oliveira
2017-04-28 12:44 ` Chauhan, Madhav
2017-04-28 14:16 ` Ander Conselvan De Oliveira
2017-04-28 11:02 ` ✓ Fi.CI.BAT: success for " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox