From: "Pandiyan, Dhinakaran" <dhinakaran.pandiyan@intel.com>
To: "puthik@chromium.org" <puthik@chromium.org>
Cc: "intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH v6 8/9] drm: Add definition for eDP backlight frequency
Date: Thu, 11 May 2017 01:09:49 +0000 [thread overview]
Message-ID: <1494466183.23186.7.camel@dk-H97M-D3H> (raw)
In-Reply-To: <20170509234052.189575-9-puthik@chromium.org>
On Tue, 2017-05-09 at 16:40 -0700, Puthikorn Voravootivat wrote:
> This patch adds the following definition
> - Bit mask for EDP_PWMGEN_BIT_COUNT and min/max cap
> register which only use bit 0:4
> - Base frequency (27 MHz) for backlight PWM frequency
> generator.
>
> Signed-off-by: Puthikorn Voravootivat <puthik@chromium.org>
> ---
> include/drm/drm_dp_helper.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
> index c0bd0d7651a9..810b7d5d9f2b 100644
> --- a/include/drm/drm_dp_helper.h
> +++ b/include/drm/drm_dp_helper.h
> @@ -572,10 +572,12 @@
> #define DP_EDP_PWMGEN_BIT_COUNT 0x724
> #define DP_EDP_PWMGEN_BIT_COUNT_CAP_MIN 0x725
> #define DP_EDP_PWMGEN_BIT_COUNT_CAP_MAX 0x726
> +# define DP_EDP_PWMGEN_BIT_COUNT_MASK (0x1f << 0)
>
> #define DP_EDP_BACKLIGHT_CONTROL_STATUS 0x727
>
> #define DP_EDP_BACKLIGHT_FREQ_SET 0x728
> +# define DP_EDP_BACKLIGHT_FREQ_BASE 27000000
I have seen frequency values expressed in kHz in most places within drm,
I think it's best to write this also in kHz to avoid confusion. With the
units addressed,
Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
>
> #define DP_EDP_BACKLIGHT_FREQ_CAP_MIN_MSB 0x72a
> #define DP_EDP_BACKLIGHT_FREQ_CAP_MIN_MID 0x72b
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-05-11 1:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-09 23:40 [PATCH v6 0/9] Enhancement to intel_dp_aux_backlight driver Puthikorn Voravootivat
2017-05-09 23:40 ` [PATCH v6 1/9] drm/i915: Fix cap check for " Puthikorn Voravootivat
2017-05-11 0:14 ` Pandiyan, Dhinakaran
2017-05-09 23:40 ` [PATCH v6 2/9] drm/i915: Correctly enable backlight brightness adjustment via DPCD Puthikorn Voravootivat
2017-05-09 23:40 ` [PATCH v6 3/9] drm/i915: Drop AUX backlight enable check for backlight control Puthikorn Voravootivat
2017-05-11 0:39 ` Pandiyan, Dhinakaran
2017-05-11 21:01 ` Puthikorn Voravootivat
2017-05-09 23:40 ` [PATCH v6 4/9] drm/i915: Allow choosing how to adjust brightness if both supported Puthikorn Voravootivat
2017-05-11 0:50 ` Pandiyan, Dhinakaran
2017-05-09 23:40 ` [PATCH v6 5/9] drm/i915: Set backlight mode before enable backlight Puthikorn Voravootivat
2017-05-09 23:40 ` [PATCH v6 6/9] drm/i915: Support dynamic backlight via DPCD register Puthikorn Voravootivat
2017-05-11 5:45 ` Pandiyan, Dhinakaran
2017-05-09 23:40 ` [PATCH v6 7/9] drm/i915: Restore brightness level in aux backlight driver Puthikorn Voravootivat
2017-05-09 23:40 ` [PATCH v6 8/9] drm: Add definition for eDP backlight frequency Puthikorn Voravootivat
2017-05-11 1:09 ` Pandiyan, Dhinakaran [this message]
2017-05-09 23:40 ` [PATCH v6 9/9] drm/i915: Set PWM divider to match desired frequency in vbt Puthikorn Voravootivat
2017-05-10 7:45 ` ✗ Fi.CI.BAT: failure for Enhancement to intel_dp_aux_backlight driver (rev5) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1494466183.23186.7.camel@dk-H97M-D3H \
--to=dhinakaran.pandiyan@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=puthik@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox