From: Puthikorn Voravootivat <puthik@chromium.org>
To: intel-gfx@lists.freedesktop.org,
Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Cc: Puthikorn Voravootivat <puthik@chromium.org>,
dri-devel@lists.freedesktop.org
Subject: [PATCH v6 5/9] drm/i915: Set backlight mode before enable backlight
Date: Tue, 9 May 2017 16:40:48 -0700 [thread overview]
Message-ID: <20170509234052.189575-6-puthik@chromium.org> (raw)
In-Reply-To: <20170509234052.189575-1-puthik@chromium.org>
We should set backlight mode register before set register to
enable the backlight.
Signed-off-by: Puthikorn Voravootivat <puthik@chromium.org>
Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
---
drivers/gpu/drm/i915/intel_dp_aux_backlight.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_dp_aux_backlight.c b/drivers/gpu/drm/i915/intel_dp_aux_backlight.c
index e82f7cb9a7af..5ef3ade7c40e 100644
--- a/drivers/gpu/drm/i915/intel_dp_aux_backlight.c
+++ b/drivers/gpu/drm/i915/intel_dp_aux_backlight.c
@@ -103,8 +103,6 @@ static void intel_dp_aux_enable_backlight(struct intel_connector *connector)
uint8_t dpcd_buf = 0;
uint8_t edp_backlight_mode = 0;
- set_aux_backlight_enable(intel_dp, true);
-
if (drm_dp_dpcd_readb(&intel_dp->aux,
DP_EDP_BACKLIGHT_MODE_SET_REGISTER, &dpcd_buf) != 1) {
DRM_DEBUG_KMS("Failed to read DPCD register 0x%x\n",
@@ -131,6 +129,8 @@ static void intel_dp_aux_enable_backlight(struct intel_connector *connector)
default:
break;
}
+
+ set_aux_backlight_enable(intel_dp, true);
}
static void intel_dp_aux_disable_backlight(struct intel_connector *connector)
--
2.13.0.rc2.291.g57267f2277-goog
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-05-09 23:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-09 23:40 [PATCH v6 0/9] Enhancement to intel_dp_aux_backlight driver Puthikorn Voravootivat
2017-05-09 23:40 ` [PATCH v6 1/9] drm/i915: Fix cap check for " Puthikorn Voravootivat
2017-05-11 0:14 ` Pandiyan, Dhinakaran
2017-05-09 23:40 ` [PATCH v6 2/9] drm/i915: Correctly enable backlight brightness adjustment via DPCD Puthikorn Voravootivat
2017-05-09 23:40 ` [PATCH v6 3/9] drm/i915: Drop AUX backlight enable check for backlight control Puthikorn Voravootivat
2017-05-11 0:39 ` Pandiyan, Dhinakaran
2017-05-11 21:01 ` Puthikorn Voravootivat
2017-05-09 23:40 ` [PATCH v6 4/9] drm/i915: Allow choosing how to adjust brightness if both supported Puthikorn Voravootivat
2017-05-11 0:50 ` Pandiyan, Dhinakaran
2017-05-09 23:40 ` Puthikorn Voravootivat [this message]
2017-05-09 23:40 ` [PATCH v6 6/9] drm/i915: Support dynamic backlight via DPCD register Puthikorn Voravootivat
2017-05-11 5:45 ` Pandiyan, Dhinakaran
2017-05-09 23:40 ` [PATCH v6 7/9] drm/i915: Restore brightness level in aux backlight driver Puthikorn Voravootivat
2017-05-09 23:40 ` [PATCH v6 8/9] drm: Add definition for eDP backlight frequency Puthikorn Voravootivat
2017-05-11 1:09 ` Pandiyan, Dhinakaran
2017-05-09 23:40 ` [PATCH v6 9/9] drm/i915: Set PWM divider to match desired frequency in vbt Puthikorn Voravootivat
2017-05-10 7:45 ` ✗ Fi.CI.BAT: failure for Enhancement to intel_dp_aux_backlight driver (rev5) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170509234052.189575-6-puthik@chromium.org \
--to=puthik@chromium.org \
--cc=dhinakaran.pandiyan@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox