From: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: remove debug fmax
Date: Mon, 1 Nov 2010 16:57:02 -0400 [thread overview]
Message-ID: <20101101165702.57e5264c@jbarnes-x201> (raw)
In-Reply-To: <20101101162605.6c2c11d7@jbarnes-x201>
On Mon, 1 Nov 2010 16:26:05 -0400
Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> Accidentally got pushed when we added power monitoring support. We
> need IPS to modify this value rather than always setting it to the
> max.
>
> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c
> b/drivers/gpu/drm/i915/intel_display.c index 4954af2..688b51d 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -5588,7 +5588,6 @@ void ironlake_enable_drps(struct drm_device
> *dev) fmin = (rgvmodectl & MEMMODE_FMIN_MASK);
> fstart = (rgvmodectl & MEMMODE_FSTART_MASK) >>
> MEMMODE_FSTART_SHIFT;
> - fstart = fmax;
>
> vstart = (I915_READ(PXVFREQ_BASE + (fstart * 4)) &
> PXVFREQ_PX_MASK) >> PXVFREQ_PX_SHIFT;
This is necessary but not sufficient. We also need to clamp the
initial max_delay at fstart and leave fmax alone (patch from Eric on
its way).
--
Jesse Barnes, Intel Open Source Technology Center
prev parent reply other threads:[~2010-11-01 20:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-01 20:26 [PATCH] drm/i915: remove debug fmax Jesse Barnes
2010-11-01 20:57 ` Jesse Barnes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101101165702.57e5264c@jbarnes-x201 \
--to=jbarnes@virtuousgeek.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox