* [PATCH] drm/i915: remove debug fmax
@ 2010-11-01 20:26 Jesse Barnes
2010-11-01 20:57 ` Jesse Barnes
0 siblings, 1 reply; 2+ messages in thread
From: Jesse Barnes @ 2010-11-01 20:26 UTC (permalink / raw)
To: intel-gfx
Accidentally got pushed when we added power monitoring support. We need
IPS to modify this value rather than always setting it to the max.
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 4954af2..688b51d 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -5588,7 +5588,6 @@ void ironlake_enable_drps(struct drm_device *dev)
fmin = (rgvmodectl & MEMMODE_FMIN_MASK);
fstart = (rgvmodectl & MEMMODE_FSTART_MASK) >>
MEMMODE_FSTART_SHIFT;
- fstart = fmax;
vstart = (I915_READ(PXVFREQ_BASE + (fstart * 4)) & PXVFREQ_PX_MASK) >>
PXVFREQ_PX_SHIFT;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/i915: remove debug fmax
2010-11-01 20:26 [PATCH] drm/i915: remove debug fmax Jesse Barnes
@ 2010-11-01 20:57 ` Jesse Barnes
0 siblings, 0 replies; 2+ messages in thread
From: Jesse Barnes @ 2010-11-01 20:57 UTC (permalink / raw)
Cc: intel-gfx
On Mon, 1 Nov 2010 16:26:05 -0400
Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> Accidentally got pushed when we added power monitoring support. We
> need IPS to modify this value rather than always setting it to the
> max.
>
> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c
> b/drivers/gpu/drm/i915/intel_display.c index 4954af2..688b51d 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -5588,7 +5588,6 @@ void ironlake_enable_drps(struct drm_device
> *dev) fmin = (rgvmodectl & MEMMODE_FMIN_MASK);
> fstart = (rgvmodectl & MEMMODE_FSTART_MASK) >>
> MEMMODE_FSTART_SHIFT;
> - fstart = fmax;
>
> vstart = (I915_READ(PXVFREQ_BASE + (fstart * 4)) &
> PXVFREQ_PX_MASK) >> PXVFREQ_PX_SHIFT;
This is necessary but not sufficient. We also need to clamp the
initial max_delay at fstart and leave fmax alone (patch from Eric on
its way).
--
Jesse Barnes, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-11-01 20:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-01 20:26 [PATCH] drm/i915: remove debug fmax Jesse Barnes
2010-11-01 20:57 ` Jesse Barnes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox