Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Kenneth Graunke <kenneth@whitecape.org>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Use PIPE_CONTROL for flushing on gen6+.
Date: Mon, 3 Oct 2011 13:00:16 -0700	[thread overview]
Message-ID: <20111003130016.61bcc8c0@jbarnes-desktop> (raw)
In-Reply-To: <1317063563-1526-1-git-send-email-kenneth@whitecape.org>

On Mon, 26 Sep 2011 11:59:23 -0700
Kenneth Graunke <kenneth@whitecape.org> wrote:

> +	/* Just flush everything for now */
> +	flags |= PIPE_CONTROL_WC_FLUSH;
> +	flags |= PIPE_CONTROL_IS_FLUSH;
> +	flags |= PIPE_CONTROL_TC_FLUSH;
> +	flags |= PIPE_CONTROL_DEPTH_FLUSH;
> +	flags |= PIPE_CONTROL_VFC;

This is the only bit I'd like to see changed.  While we still have the
domain tracking code we may as well try to honor it and limit our
flushing here like we do with MI_FLUSH.

Unless someone has a "remove all domain tracking" patch already posted
that is. :)

-- 
Jesse Barnes, Intel Open Source Technology Center

  parent reply	other threads:[~2011-10-03 20:00 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-26 18:59 [PATCH] drm/i915: Use PIPE_CONTROL for flushing on gen6+ Kenneth Graunke
2011-09-26 19:16 ` Chris Wilson
2011-09-26 19:23   ` Daniel Vetter
2011-09-26 19:43     ` Chris Wilson
2011-09-26 20:15   ` Keith Packard
2011-09-26 20:21   ` Kenneth Graunke
2011-09-26 20:31 ` Daniel Vetter
2011-09-26 20:38   ` Kenneth Graunke
2011-09-26 22:25     ` Eric Anholt
2011-10-03 20:00 ` Jesse Barnes [this message]
2011-10-03 21:14   ` Keith Packard
2011-10-03 21:21     ` Jesse Barnes
2011-10-03 22:59   ` Eric Anholt
2011-10-03 23:16     ` Jesse Barnes
  -- strict thread matches above, loose matches on Subject: below --
2011-10-11 21:41 [PATCH 3/3] " Daniel Vetter
2011-10-16  8:23 ` [PATCH] " Daniel Vetter
2011-10-17  1:27   ` Ben Widawsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111003130016.61bcc8c0@jbarnes-desktop \
    --to=jbarnes@virtuousgeek.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=kenneth@whitecape.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox