public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Joonyoung Shim <jy0922.shim@samsung.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	rob.clark@linaro.org
Subject: Re: [PATCH 1/5] drm: add plane support
Date: Fri, 4 Nov 2011 07:10:41 -0700	[thread overview]
Message-ID: <20111104071041.60aa47d8@jbarnes-desktop> (raw)
In-Reply-To: <4EB34C52.2010104@samsung.com>


[-- Attachment #1.1: Type: text/plain, Size: 741 bytes --]

On Fri, 04 Nov 2011 11:22:10 +0900
Joonyoung Shim <jy0922.shim@samsung.com> wrote:
> > +struct drm_plane {
> > +	struct drm_device *dev;
> > +	struct device kdev;
> > +	struct device_attribute *attr;
> > +	struct list_head head;
> > +
> > +	struct drm_mode_object base;
> > +
> > +	uint32_t possible_crtcs;
> > +	uint32_t *format_types;
> > +	uint32_t format_count;
> > +
> > +	struct drm_crtc *crtc;
> > +	struct drm_framebuffer *fb;
> 
> Where are crtc and fb of struct drm_plane assigned?
> First, i did it in device specific update_plane, but can do in
> drm_mode_setplane?

Yeah it should probably be done in setplane if there's no error.  Fixed.

Thanks,
-- 
Jesse Barnes, Intel Open Source Technology Center

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2011-11-04 14:10 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-02 20:03 [PATCH] DRM planes Jesse Barnes
2011-11-02 20:03 ` [PATCH 1/5] drm: add plane support Jesse Barnes
2011-11-02 22:33   ` Jesse Barnes
2011-11-03 18:21     ` Jesse Barnes
2011-11-03 22:48       ` Jesse Barnes
2011-11-03 22:56         ` Daniel Vetter
2011-11-04  2:22   ` Joonyoung Shim
2011-11-04 14:10     ` Jesse Barnes [this message]
2011-11-02 20:03 ` [PATCH 2/5] drm: add an fb creation ioctl that takes a pixel format Jesse Barnes
2011-11-03 18:22   ` Jesse Barnes
2011-11-04  7:34   ` Joonyoung Shim
2011-11-04 14:13     ` Jesse Barnes
2011-11-02 20:03 ` [PATCH 3/5] drm/i915: rename existing overlay support to "legacy" Jesse Barnes
2011-11-03 18:22   ` Jesse Barnes
2011-11-02 20:03 ` [PATCH 4/5] drm/i915: add SNB and IVB video sprite support Jesse Barnes
2011-11-03 18:22   ` Jesse Barnes
2011-11-04  2:29   ` [Intel-gfx] " Lan, Hai
2011-11-02 20:03 ` [PATCH 5/5] drm/i915: add destination color key support Jesse Barnes
2011-11-03 18:23   ` Jesse Barnes
2011-11-03 14:11 ` [PATCH] DRM planes Daniel Vetter
2011-11-03 15:12   ` Jesse Barnes
2011-11-03 17:29     ` Daniel Vetter
2011-11-03 17:36       ` Jesse Barnes
2011-11-03 18:55         ` Rob Clark
2011-11-03 19:14           ` Jesse Barnes
2011-11-03 17:47   ` Alan Cox
2011-11-03 18:58     ` Daniel Vetter
2011-11-03 22:20       ` Alan Cox
2011-11-03 22:24         ` Jesse Barnes
  -- strict thread matches above, loose matches on Subject: below --
2011-11-07 18:02 Jesse Barnes
2011-11-07 18:02 ` [PATCH 1/5] drm: add plane support Jesse Barnes
2011-11-08 14:20   ` Daniel Vetter
2011-11-08 16:34     ` Jesse Barnes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111104071041.60aa47d8@jbarnes-desktop \
    --to=jbarnes@virtuousgeek.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jy0922.shim@samsung.com \
    --cc=rob.clark@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox