Re: [PATCH 4/5] drm/i915: add destination color key support

[Daniel Vetter <daniel@ffwll.ch>]

On Tue, Nov 08, 2011 at 05:36:11PM -0500, Alex Deucher wrote:
> On Tue, Nov 8, 2011 at 5:06 PM, Daniel Vetter <daniel@ffwll.ch> wrote:
> > On Mon, Nov 07, 2011 at 10:02:55AM -0800, Jesse Barnes wrote:
> >> Add new ioctls for getting and setting the current destination color
> >> key.  This allows for simple overlay display control by matching a color
> >> key value in the primary plane before blending the overlay on top.
> >>
> >> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> >
> > A few comments below and a snide-y one here: If the goal is simply to keep
> > the bubble intact, this is fine by me. If we want something that has the
> > chance to be useable by a generic driver I think we want a drm interface
> > for plane/crtc properties (you could wire up set_gamma on planes in the
> > same series ... ;-) Again, I don't really care ...
> 
> Even further off topic, the panel scaler support should ideally be a
> property of crtcs/planes rather than a connector property.  However,
> that would be a bit of pain to implement and keep backwards
> compatibility.

I think we could just internally route the output pannel-fitter prop to
the crtc one. After all if the hw has the fitter really on the crtc,
moving it also logically to the crtc won't make anything previously
possibel impossible ...
-Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48