From: Daniel Vetter <daniel@ffwll.ch>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
rob.clark@linaro.org
Subject: Re: [Intel-gfx] [PATCH 3/5] drm/i915: add SNB and IVB video sprite support
Date: Tue, 8 Nov 2011 23:16:19 +0100 [thread overview]
Message-ID: <20111108221619.GF4754@phenom.ffwll.local> (raw)
In-Reply-To: <20111108215703.GC4754@phenom.ffwll.local>
On Tue, Nov 08, 2011 at 10:57:03PM +0100, Daniel Vetter wrote:
> > + /*
> > + * Clamp the width & height into the visible area. Note we don't
> > + * try to scale the source if part of the visible region is offscreen.
> > + * The caller must handle that by adjusting source offset and size.
> > + */
>
> Allowing the crtc dest rect to extend beyond that of the crtc and then refusing to
> properly adjust tiling is a bit inconsistent. I call design-by-committee
> on this one ;-)
Oops, that comment went fubar while transferring from brainwaves to bits.
Instead of "adjust tiling" it should be "adjust the source rectangle to
the restricted crtc dest".
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
next prev parent reply other threads:[~2011-11-08 22:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-07 18:02 [PATCH] DRM planes Jesse Barnes
2011-11-07 18:02 ` [PATCH 1/5] drm: add plane support Jesse Barnes
2011-11-08 14:20 ` Daniel Vetter
2011-11-08 16:34 ` Jesse Barnes
2011-11-07 18:02 ` [PATCH 2/5] drm: add an fb creation ioctl that takes a pixel format Jesse Barnes
2011-11-07 18:02 ` [PATCH 3/5] drm/i915: add SNB and IVB video sprite support Jesse Barnes
2011-11-08 21:57 ` Daniel Vetter
2011-11-08 22:16 ` Daniel Vetter [this message]
2011-11-08 22:31 ` Jesse Barnes
2011-11-08 22:57 ` [Intel-gfx] " Daniel Vetter
2011-11-07 18:02 ` [PATCH 4/5] drm/i915: add destination color key support Jesse Barnes
2011-11-08 22:06 ` Daniel Vetter
2011-11-08 22:36 ` Alex Deucher
2011-11-08 23:08 ` Daniel Vetter
2011-11-08 22:40 ` Jesse Barnes
2011-11-07 18:02 ` [PATCH 5/5] drm/i915: track sprite coverage and disable primary plane if possible Jesse Barnes
2011-11-08 22:08 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111108221619.GF4754@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
--cc=rob.clark@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox