Re: [PATCH 4/5] drm/i915: add destination color key support

From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	rob.clark@linaro.org
Subject: Re: [PATCH 4/5] drm/i915: add destination color key support
Date: Tue, 8 Nov 2011 14:40:43 -0800	[thread overview]
Message-ID: <20111108144043.1e0c1258@jbarnes-desktop> (raw)
In-Reply-To: <20111108220657.GD4754@phenom.ffwll.local>

[-- Attachment #1.1: Type: text/plain, Size: 1651 bytes --]

On Tue, 8 Nov 2011 23:06:57 +0100
Daniel Vetter <daniel@ffwll.ch> wrote:

> On Mon, Nov 07, 2011 at 10:02:55AM -0800, Jesse Barnes wrote:
> > Add new ioctls for getting and setting the current destination color
> > key.  This allows for simple overlay display control by matching a color
> > key value in the primary plane before blending the overlay on top.
> > 
> > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> 
> A few comments below and a snide-y one here: If the goal is simply to keep
> the bubble intact, this is fine by me. If we want something that has the
> chance to be useable by a generic driver I think we want a drm interface
> for plane/crtc properties (you could wire up set_gamma on planes in the
> same series ... ;-) Again, I don't really care ...

I'm ok with having generic properties for these.  But I don't want to
go through the same 8 month process of getting buy-in from other
chipsets and people before the code is pushed as I've done with the
core DRM bits.

And since I know nothing of the color key support details for other
chipsets, I've simply made this one device specific.  We'll have more
in the future too; current hardware can do source keying, and future
hardware will be able to blend 3 planes per pipe together using alpha
blending.

If some other hardware has similar features and someone steps up to do
the code, I'd be happy to work with them to get some generic interfaces
in.  In the meantime though, I'd like to see some i915 interfaces so we
can actually use this stuff before the world ends in 2012.

-- 
Jesse Barnes, Intel Open Source Technology Center

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx