Re: [PATCH] iommu/intel: Fix build failure with intel-gtt and !intel-iommu

Re: [PATCH] iommu/intel: Fix build failure with intel-gtt and !intel-iommu

[David Woodhouse]

[-- Attachment #1: Type: text/plain, Size: 607 bytes --]

On Fri, 2011-11-11 at 14:48 +0100, Joerg Roedel wrote:
> +#define intel_iommu_gfx_mapped 1 

That ought to be zero; if the IOMMU code isn't present, it's
*definitely* not mapped through the IOMMU :)

But I'm fairly sure this was already noticed and a patch is on its way
upstream already.

It's my fault — my original testing patches to expose this information
from the IOMMU code did put it into a header file, but when I sent it
upstream I missed that part of the patch, thus leading to the horrid
'extern int intel_iommu_gfx_mapped;' in intel-gtt.c that your patch
removes.

-- 
dwmw2

[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5818 bytes --]

Re: [PATCH] iommu/intel: Fix build failure with intel-gtt and !intel-iommu

[Joerg Roedel]

On Fri, Nov 11, 2011 at 01:52:33PM +0000, David Woodhouse wrote:
> On Fri, 2011-11-11 at 14:48 +0100, Joerg Roedel wrote:
> > +#define intel_iommu_gfx_mapped 1 
> 
> That ought to be zero; if the IOMMU code isn't present, it's
> *definitely* not mapped through the IOMMU :)
> 
> But I'm fairly sure this was already noticed and a patch is on its way
> upstream already.
> 
> It's my fault — my original testing patches to expose this information
> from the IOMMU code did put it into a header file, but when I sent it
> upstream I missed that part of the patch, thus leading to the horrid
> 'extern int intel_iommu_gfx_mapped;' in intel-gtt.c that your patch
> removes.

No problem, it was easy to fix :) I'll keep that patch in my out-of-tree
branch until it is fixed upstream.


	Joerg

-- 
AMD Operating System Research Center

Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632

Re: [PATCH] iommu/intel: Fix build failure with intel-gtt and !intel-iommu

[Joerg Roedel]

On Fri, Nov 11, 2011 at 01:52:33PM +0000, David Woodhouse wrote:
> On Fri, 2011-11-11 at 14:48 +0100, Joerg Roedel wrote:
> > +#define intel_iommu_gfx_mapped 1 
> 
> That ought to be zero; if the IOMMU code isn't present, it's
> *definitely* not mapped through the IOMMU :)

Okay, I change this to 0 in my patch.

> But I'm fairly sure this was already noticed and a patch is on its way
> upstream already.

It is not yet fixed upstream. I plan to send fixes to Linus soon. Any
objection against me including this if its not fixed until then?


	Joerg


-- 
AMD Operating System Research Center

Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632

Re: [PATCH] iommu/intel: Fix build failure with intel-gtt and !intel-iommu

[Dave Airlie]

> 
> > But I'm fairly sure this was already noticed and a patch is on its way
> > upstream already.
> 
> It is not yet fixed upstream. I plan to send fixes to Linus soon. Any
> objection against me including this if its not fixed until then?

Does a08185a3eb658854b29c05bcbfac0f85038ffe9f in Linus tree not fix it?

Dave.

Re: [PATCH] iommu/intel: Fix build failure with intel-gtt and !intel-iommu

[Joerg Roedel]

On Mon, Nov 14, 2011 at 01:35:13PM +0000, Dave Airlie wrote:
> 
> 
> > 
> > > But I'm fairly sure this was already noticed and a patch is on its way
> > > upstream already.
> > 
> > It is not yet fixed upstream. I plan to send fixes to Linus soon. Any
> > objection against me including this if its not fixed until then?
> 
> Does a08185a3eb658854b29c05bcbfac0f85038ffe9f in Linus tree not fix it?

Oops, tested the wrong tree. It is fixed indeed. Sorry for the noise :)


	Joerg

-- 
AMD Operating System Research Center

Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632