From: Daniel Vetter <daniel@ffwll.ch>
To: Eric Anholt <eric@anholt.net>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915: Correct the bit number for the MI_FLUSH_ENABLE.
Date: Sat, 21 Jan 2012 17:36:13 +0100 [thread overview]
Message-ID: <20120121163613.GE3821@phenom.ffwll.local> (raw)
In-Reply-To: <1326999006-15100-2-git-send-email-eric@anholt.net>
On Thu, Jan 19, 2012 at 10:50:06AM -0800, Eric Anholt wrote:
> Older specs claimed this was bit 11, but newer specs and the actual
> simulator code say it was bit 12. Regardless, we don't use MI_FLUSH,
> or try to enable it any more.
>
> Signed-off-by: Eric Anholt <eric@anholt.net>
I'd like to amend this with the following (on this patch instead of the
other, so that ppl actually can find it with git blame):
"Furthermore actually setting bit12 results in gpu hangs both on snb and
ivb. Ben Widawsky discovered a ppt that claims that both bit12 and bit11
must be set, but that doesn't help either. And last but not least,
MI_FLUSH seems to work regardless of the setting of these bits."
Eric, Ben, is that ok?
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
next prev parent reply other threads:[~2012-01-21 16:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-19 18:50 [PATCH 1/2] drm/i915: Remove the MI_FLUSH_ENABLE setting Eric Anholt
2012-01-19 18:50 ` [PATCH 2/2] drm/i915: Correct the bit number for the MI_FLUSH_ENABLE Eric Anholt
2012-01-21 16:36 ` Daniel Vetter [this message]
2012-01-25 2:55 ` Eric Anholt
2012-01-25 4:22 ` Ben Widawsky
2012-01-25 8:37 ` Daniel Vetter
2012-01-25 9:57 ` Chris Wilson
2012-01-25 10:41 ` Daniel Vetter
2012-01-25 18:31 ` Eric Anholt
2012-01-19 18:53 ` [PATCH 1/2] drm/i915: Remove the MI_FLUSH_ENABLE setting Daniel Vetter
2012-01-19 18:54 ` Keith Packard
2012-01-19 18:59 ` Ben Widawsky
2012-01-19 19:36 ` Keith Packard
2012-01-20 19:16 ` Eric Anholt
2012-01-20 22:57 ` Ben Widawsky
2012-01-21 0:40 ` Eric Anholt
2012-01-21 4:47 ` Ben Widawsky
2012-01-21 10:57 ` Kenneth Graunke
2012-01-21 21:32 ` Ben Widawsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120121163613.GE3821@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=eric@anholt.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox