From: Ben Widawsky <ben@bwidawsk.net>
To: Eric Anholt <eric@anholt.net>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915: Remove the MI_FLUSH_ENABLE setting.
Date: Fri, 20 Jan 2012 14:57:44 -0800 [thread overview]
Message-ID: <4F19F168.1080506@bwidawsk.net> (raw)
In-Reply-To: <87ty3qnq0v.fsf@eliezer.anholt.net>
On 01/20/2012 11:16 AM, Eric Anholt wrote:
> On Thu, 19 Jan 2012 10:59:57 -0800, Ben Widawsky <ben@bwidawsk.net> wrote:
>> On 01/19/2012 10:54 AM, Keith Packard wrote:
>>> On Thu, 19 Jan 2012 10:50:05 -0800, Eric Anholt <eric@anholt.net> wrote:
>>>
>>>> - if (IS_GEN6(dev) || IS_GEN7(dev))
>>>> - mode |= MI_FLUSH_ENABLE << 16 | MI_FLUSH_ENABLE;
>>>
>>> This seems better than setting random bits that don't do anything but
>>> annoy the simulator.
>>
>> The simulator complains unless both bits are set iirc. I can double
>> check, but it's been a while since I've run without my patch.
>
> Can you please cite the message you're getting? I've read a lot of the
> simulator at this point, particularly pieces relating to flushing, and I
> can't find what you're talking about.
>
It is not email friendly paste.
Gen7GT/Render/src/CsMiCommonCatcher.cpp +293
It links to a power point which shows the workaround is to set both
bits. The powerpoint is kind enough to crash libreoffice for me.
Ben
next prev parent reply other threads:[~2012-01-20 22:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-19 18:50 [PATCH 1/2] drm/i915: Remove the MI_FLUSH_ENABLE setting Eric Anholt
2012-01-19 18:50 ` [PATCH 2/2] drm/i915: Correct the bit number for the MI_FLUSH_ENABLE Eric Anholt
2012-01-21 16:36 ` Daniel Vetter
2012-01-25 2:55 ` Eric Anholt
2012-01-25 4:22 ` Ben Widawsky
2012-01-25 8:37 ` Daniel Vetter
2012-01-25 9:57 ` Chris Wilson
2012-01-25 10:41 ` Daniel Vetter
2012-01-25 18:31 ` Eric Anholt
2012-01-19 18:53 ` [PATCH 1/2] drm/i915: Remove the MI_FLUSH_ENABLE setting Daniel Vetter
2012-01-19 18:54 ` Keith Packard
2012-01-19 18:59 ` Ben Widawsky
2012-01-19 19:36 ` Keith Packard
2012-01-20 19:16 ` Eric Anholt
2012-01-20 22:57 ` Ben Widawsky [this message]
2012-01-21 0:40 ` Eric Anholt
2012-01-21 4:47 ` Ben Widawsky
2012-01-21 10:57 ` Kenneth Graunke
2012-01-21 21:32 ` Ben Widawsky
-- strict thread matches above, loose matches on Subject: below --
2012-01-21 1:52 Ben Widawsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F19F168.1080506@bwidawsk.net \
--to=ben@bwidawsk.net \
--cc=eric@anholt.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox