From: Ben Widawsky <ben@bwidawsk.net>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2 3/3] tests: rc6 residency test
Date: Mon, 26 Mar 2012 14:54:35 -0700 [thread overview]
Message-ID: <20120326145435.7a296690@bwidawsk.net> (raw)
In-Reply-To: <20120326094055.GL4014@phenom.ffwll.local>
On Mon, 26 Mar 2012 11:40:55 +0200
Daniel Vetter <daniel@ffwll.ch> wrote:
> On Mon, Mar 26, 2012 at 11:37:13AM +0200, Daniel Vetter wrote:
> > On Sun, Mar 25, 2012 at 05:33:32PM -0700, Ben Widawsky wrote:
> > > This is meant to test the sysfs entry for showing rc6 residency in
> > > milliseconds. Remember, sysfs is a permanent interface.
> > >
> > > v2: use new get_card interface to try "all" devices
> > > check rc6p and rc6pp in addition to rc6
> > >
> > > Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
> >
> > You're still missing the drm_quiescent_gpu(fd) call before doing the
> > residency measurements. Which makes this test fail reliably in the
> > i-g-t testsuite because the gpu is still busy from previous tests.
> > Please run new tests also in the context of the full testuite to
> > catch such issues.
>
> Actually the quiescent seems to be there, so I don't know what's
> going on. -Daniel
I ran this on IVB, both individual and with make test (Ken's machine),
and it passed.
Ben
next prev parent reply other threads:[~2012-03-26 21:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-26 0:33 [PATCH v2 1/3] drm/i915: add rc6 residency times to debugfs Ben Widawsky
2012-03-26 0:33 ` [PATCH 2/3] drm/i915: extract intel_enable_rc6() Ben Widawsky
2012-03-26 9:32 ` Daniel Vetter
2012-03-26 0:33 ` [PATCH v2 3/3] drm/i915: rc6 in sysfs Ben Widawsky
2012-03-26 0:33 ` [PATCH 1/3] build: make sure we have asprintf Ben Widawsky
2012-03-26 0:33 ` [PATCH 2/3] drm/i915: extract card getting Ben Widawsky
2012-03-26 9:33 ` Daniel Vetter
2012-03-26 0:33 ` [PATCH v2 3/3] tests: rc6 residency test Ben Widawsky
2012-03-26 9:37 ` Daniel Vetter
2012-03-26 9:40 ` Daniel Vetter
2012-03-26 21:54 ` Ben Widawsky [this message]
2012-03-27 7:22 ` Daniel Vetter
2012-03-27 8:34 ` Daniel Vetter
2012-03-26 9:34 ` [PATCH v2 1/3] drm/i915: add rc6 residency times to debugfs Daniel Vetter
2012-03-26 12:33 ` Eugeni Dodonov
2012-03-26 16:49 ` Ben Widawsky
2012-03-26 22:34 ` Ben Widawsky
2012-03-26 23:04 ` Eugeni Dodonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120326145435.7a296690@bwidawsk.net \
--to=ben@bwidawsk.net \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox