From: Ben Widawsky <ben@bwidawsk.net>
To: Eugeni Dodonov <eugeni@dodonov.net>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2 1/3] drm/i915: add rc6 residency times to debugfs
Date: Mon, 26 Mar 2012 15:34:16 -0700 [thread overview]
Message-ID: <20120326153416.73b5b9b3@bwidawsk.net> (raw)
In-Reply-To: <CAC7LmnseF7muUqrV0=237kJW0TGzQYdaT5C4pzWCjaEPiwwNNw@mail.gmail.com>
On Mon, 26 Mar 2012 09:33:51 -0300
Eugeni Dodonov <eugeni@dodonov.net> wrote:
> On Mon, Mar 26, 2012 at 06:34, Daniel Vetter <daniel@ffwll.ch> wrote:
>
> > On Sun, Mar 25, 2012 at 05:33:27PM -0700, Ben Widawsky wrote:
> > > RC6 residency should be in intervals of 1.28us, and the counter
> > > wraps. Here is an example using awk to get the various RC6 and
> > > RC6+ residency times in seconds, since boot.
> > >
> > > cat /sys/kernel/debug/dri/0/i915_drpc_info | grep residency |
> > > awk -F':'
> > -F' ' '{print $5 * 1.28 / 1000000}'
> > >
> > > This is primarily for debug, and QA/application developers using
> > > the sysfs interface looking for more insight.
> > >
> > > Untested on IVB.
> >
> > Tested on my ivb, seems to yield sane numbers for the default
> > configuration (i.e. enable rc+rc6p, disable rc6pp).
> >
>
> Yeah, it should work on IVB except for some strange behavior
> sometimes (I noticed that on IVB we sometimes get into RC6 even if we
> pass the i915_enable_rc6=0 parameter). I don't know if it is Bios
> playing some tricks with us or something changed in the mailbox
> communication, but no harm came from this so far. I'll see what is
> going on there.
>
> But for the patch itself:
> Reviewed-by: Eugeni Dodonov <eugeni.dodonov@gmail.com>
>
> Nothing like new and shiny powertop power-saving options :).
>
I'd like to resubmit this patch with either %u or %x instead of the %d.
Can I still keep your r-b?
next prev parent reply other threads:[~2012-03-26 22:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-26 0:33 [PATCH v2 1/3] drm/i915: add rc6 residency times to debugfs Ben Widawsky
2012-03-26 0:33 ` [PATCH 2/3] drm/i915: extract intel_enable_rc6() Ben Widawsky
2012-03-26 9:32 ` Daniel Vetter
2012-03-26 0:33 ` [PATCH v2 3/3] drm/i915: rc6 in sysfs Ben Widawsky
2012-03-26 0:33 ` [PATCH 1/3] build: make sure we have asprintf Ben Widawsky
2012-03-26 0:33 ` [PATCH 2/3] drm/i915: extract card getting Ben Widawsky
2012-03-26 9:33 ` Daniel Vetter
2012-03-26 0:33 ` [PATCH v2 3/3] tests: rc6 residency test Ben Widawsky
2012-03-26 9:37 ` Daniel Vetter
2012-03-26 9:40 ` Daniel Vetter
2012-03-26 21:54 ` Ben Widawsky
2012-03-27 7:22 ` Daniel Vetter
2012-03-27 8:34 ` Daniel Vetter
2012-03-26 9:34 ` [PATCH v2 1/3] drm/i915: add rc6 residency times to debugfs Daniel Vetter
2012-03-26 12:33 ` Eugeni Dodonov
2012-03-26 16:49 ` Ben Widawsky
2012-03-26 22:34 ` Ben Widawsky [this message]
2012-03-26 23:04 ` Eugeni Dodonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120326153416.73b5b9b3@bwidawsk.net \
--to=ben@bwidawsk.net \
--cc=eugeni@dodonov.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox