Re: [PATCH 2/4] drm/i915: IBX+ doesn't have separate vsync/hsync controls on the VGA DAC

[Daniel Vetter <daniel@ffwll.ch>]

On Tue, Apr 17, 2012 at 11:18:46PM +0100, Chris Wilson wrote:
> On Tue, 17 Apr 2012 15:06:33 -0700, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> > Like this?
> > 
> > From fee9f6fbf2230f96b9195baf32fd67b243969a14 Mon Sep 17 00:00:00 2001
> > From: Jesse Barnes <jbarnes@virtuousgeek.org>
> > Date: Wed, 11 Apr 2012 09:23:34 -0700
> > Subject: [PATCH] drm/i915: IBX+ doesn't have separate vsync/hsync controls on
> >  the VGA DAC
> > 
> > When the PCH split occurred, we dropped support for separate hsync and
> > vsync disable in the VGA DAC.  So add a PCH specific DPMS function that
> > just uses the port enable bit for controlling DPMS states.
> > 
> > Before this fix, when anything other than a full DPMS off occurred,
> > the VGA port would be left enabled and scanning out while all the other
> > heads would turn off as expected.
> > 
> > v2: duplicate encoder helper vtable into pch and gmch versions (Daniel)
> > 
> > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> 
> With s/intel_crt_dpms/gmch_crt_dpms/ and
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=48491
> 
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Queued for next with the gmch_ color applied, thanks for the patch&review.
-Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48