public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH] drm/i915: implement Disable4x2SubspanOptimization w/a for ivb, too
Date: Wed, 18 Apr 2012 11:21:34 +0200	[thread overview]
Message-ID: <20120418092134.GJ5315@phenom.ffwll.local> (raw)
In-Reply-To: <1334444040-5697-1-git-send-email-daniel.vetter@ffwll.ch>

On Sun, Apr 15, 2012 at 12:54:00AM +0200, Daniel Vetter wrote:
> Copy&pasted from the vlv setup code. According to docs, we need that
> on ivb, too.
> 
> Cc: Ben Widawsky <ben@bwidawsk.net>
> Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Ben, can you please take a look at this?

Thanks, Daniel

> ---
>  drivers/gpu/drm/i915/intel_display.c |    5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 33aaad3..7be1d1a 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -8938,6 +8938,11 @@ static void ivybridge_init_clock_gating(struct drm_device *dev)
>  			   DISPPLANE_TRICKLE_FEED_DISABLE);
>  		intel_flush_display_plane(dev_priv, pipe);
>  	}
> +
> +	/* WaDisable4x2SubspanOptimization */
> +	I915_WRITE(CACHE_MODE_1, I915_READ(CACHE_MODE_1) |
> +		   (PIXEL_SUBSPAN_COLLECT_OPT_DISABLE << 16) |
> +		   PIXEL_SUBSPAN_COLLECT_OPT_DISABLE);
>  }
>  
>  static void valleyview_init_clock_gating(struct drm_device *dev)
> -- 
> 1.7.10
> 

-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48

  reply	other threads:[~2012-04-18  9:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-14 22:54 [PATCH] drm/i915: implement Disable4x2SubspanOptimization w/a for ivb, too Daniel Vetter
2012-04-18  9:21 ` Daniel Vetter [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-04-24 14:00 Daniel Vetter
2012-04-24 15:57 ` Ben Widawsky
2012-04-24 16:26   ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120418092134.GJ5315@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=ben@bwidawsk.net \
    --cc=daniel.vetter@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox