public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Carsten Emde <C.Emde@osadl.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
	Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 1/2] drm/i915: clear up backlight inversion confusion on gen4
Date: Mon, 23 Apr 2012 17:56:05 +0200	[thread overview]
Message-ID: <20120423155605.GK4935@phenom.ffwll.local> (raw)
In-Reply-To: <4F957773.6000003@osadl.org>

On Mon, Apr 23, 2012 at 05:38:27PM +0200, Carsten Emde wrote:
> On 04/23/2012 05:22 PM, Daniel Vetter wrote:
> >On Mon, Apr 23, 2012 at 05:06:53PM +0200, Carsten Emde wrote:
> >>On 04/23/2012 04:22 PM, Daniel Vetter wrote:
> >>>On Mon, Apr 23, 2012 at 04:00:23PM +0200, Carsten Emde wrote:
> >>> [..]
> >>>The idea was to boot with kms and see whether any of these values would
> >>>restore the backlight. Writing to CTL1 should change anything in CTL2.
> >>Ah, sorry, ok. Removed the quirk again and tested the various settings:
> >>
> >>->  Initial screen: dark
> >>
> >># intel_reg_write 0x61250 0x80000000
> >>Value before: 0xE0000000
> >>Value after: 0x80000000
> >>->  Still dark
> >>
> >># intel_reg_write 0x61250 0xa0000000
> >>Value before: 0x80000000
> >>Value after: 0xA0000000
> >>->  Still dark
> >>
> >># intel_reg_write 0x61250 0x90000000
> >>Value before: 0xA0000000
> >>Value after: 0x90000000
> >>->  BACKLIGHT ON!
> >>
> >># intel_reg_write 0x61250 0xb0000000
> >>Value before: 0x90000000
> >>Value after: 0xB0000000
> >>->  Still ON.
> >
> >Neat. Let's test two more:
> >
> ># intel_reg_write 0x61250 0xd0000000
> ># intel_reg_write 0x61250 0xc0000000
> Here we go.
> 
> ->  Initial screen: dark
> 
> # intel_reg_write 0x61250 0xd0000000
> Value before: 0xE0000000
> Value after: 0xD0000000
> ->  BACKLIGHT ON!
> 
> # intel_reg_write 0x61250 0xc0000000
> Value before: 0xD0000000
> Value after: 0xC0000000
> ->  Dark again.

Ok, so the polarity bit does work as advertised. But I still don't
understand how your machine works, so assuming your machine has backlight
control keys, please boot with kms disabled and grab the both registers
values for maximal brightness and minimal brightness. Then reconfigure the
backlight with

# intel_reg_write 0x61250 0x90000000

and check how the behaviour changes. Somehow we lose something when
setting up drm/i915, but atm I can't figure out what yet.

Thanks, Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48

  reply	other threads:[~2012-04-23 15:55 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-23  9:32 [PATCH 1/2] drm/i915: clear up backlight inversion confusion on gen4 Daniel Vetter
2012-04-23  9:32 ` [PATCH 2/2] drm/i915: pnv has a backlight polarity control bit, too Daniel Vetter
2012-04-23 10:27   ` Chris Wilson
2012-04-23  9:53 ` [PATCH 1/2] drm/i915: clear up backlight inversion confusion on gen4 Chris Wilson
2012-04-23 12:21   ` Daniel Vetter
2012-04-23 12:32     ` Chris Wilson
2012-04-23 13:48       ` Daniel Vetter
     [not found] ` <4F9542EF.3010208@osadl.org>
2012-04-23 12:32   ` Daniel Vetter
2012-04-23 12:36     ` Daniel Vetter
2012-04-23 13:15       ` Carsten Emde
2012-04-23 13:39         ` Daniel Vetter
2012-04-23 14:00           ` Carsten Emde
2012-04-23 14:22             ` Daniel Vetter
2012-04-23 15:06               ` Carsten Emde
2012-04-23 15:22                 ` Daniel Vetter
2012-04-23 15:38                   ` Carsten Emde
2012-04-23 15:56                     ` Daniel Vetter [this message]
2012-04-23 16:55                       ` Carsten Emde
2012-04-26 16:48 ` [PATCH 0/4] drm/i915: " Carsten Emde
2012-04-26 16:48   ` [PATCH 1/4] drm/i915: " Carsten Emde
2012-04-26 16:48   ` [PATCH 2/4] drm/i915: completely revert the invert brightness quirk Carsten Emde
2012-04-26 16:48   ` [PATCH 3/4] drm/i915: add quirk to indicate that an alt bit is used for brightness inversion Carsten Emde
2012-04-26 17:08     ` Daniel Vetter
2012-04-26 17:25       ` [PATCH] properly enable the blc controller on the right pipe Daniel Vetter
2012-04-26 17:27         ` Daniel Vetter
2012-04-26 19:12         ` Carsten Emde
2012-04-26 19:30           ` Daniel Vetter
2012-04-27 20:18             ` Carsten Emde
2012-06-02 23:08               ` Daniel Vetter
2012-06-11  8:51                 ` Daniel Vetter
2012-07-19 14:00                   ` Carsten Emde
2012-07-19 14:40                     ` Daniel Vetter
2012-07-19 22:51                       ` Carsten Emde
2012-07-20  8:10                         ` Daniel Vetter
2012-07-24  7:30                           ` Carsten Emde
2012-07-25 22:35                             ` Carsten Emde
2012-07-26 11:55                               ` [PATCH] drm/i915 disable combination mode Daniel Vetter
2012-07-26 12:20                               ` Daniel Vetter
2012-07-26 12:36                               ` Daniel Vetter
2012-07-26 14:09                               ` Daniel Vetter
2012-04-26 16:48   ` [PATCH 4/4] drm/i915: assign the brightness inversion quirk to Acer Aspire 5734Z Carsten Emde
2012-04-27 16:17   ` [PATCH 0/4] drm/i915: Re: clear up backlight inversion confusion on gen4 Monark Gondaliya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120423155605.GK4935@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=C.Emde@osadl.org \
    --cc=daniel.vetter@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox