* [PATCH] drm/i915: CR clock gating is recommend to be set on PineView
@ 2012-04-24 12:36 Chris Wilson
2012-04-24 13:51 ` Chris Wilson
0 siblings, 1 reply; 3+ messages in thread
From: Chris Wilson @ 2012-04-24 12:36 UTC (permalink / raw)
To: intel-gfx
The specs recommend that this bit be set on PineView. No reason is
given, but it sounds like a powersaving bit that we should expect the
BIOS to be setting...
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/i915/intel_pm.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 1e85df6..b14021b 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -2876,6 +2876,10 @@ static void gen3_init_clock_gating(struct drm_device *dev)
dstate |= DSTATE_PLL_D3_OFF | DSTATE_GFX_CLOCK_GATING |
DSTATE_DOT_CLOCK_GATING;
I915_WRITE(D_STATE, dstate);
+
+ if (IS_PINEVIEW(dev))
+ I915_WRITE(ECOSKPD,
+ ECO_GATING_CX_ONLY << 16 | ECO_GATING_CX_ONLY);
}
static void i85x_init_clock_gating(struct drm_device *dev)
--
1.7.10
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] drm/i915: CR clock gating is recommend to be set on PineView
2012-04-24 12:36 [PATCH] drm/i915: CR clock gating is recommend to be set on PineView Chris Wilson
@ 2012-04-24 13:51 ` Chris Wilson
2012-04-25 9:49 ` Daniel Vetter
0 siblings, 1 reply; 3+ messages in thread
From: Chris Wilson @ 2012-04-24 13:51 UTC (permalink / raw)
To: intel-gfx
The specs recommend that this bit be set on PineView. No reason is
given, but it sounds like a powersaving bit that we should expect the
BIOS to be setting...
v2: Rebase on top of _MASKED_ENABLE_BIT
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/i915/intel_pm.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 98756d2..e684a63 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -2875,6 +2875,9 @@ static void gen3_init_clock_gating(struct drm_device *dev)
dstate |= DSTATE_PLL_D3_OFF | DSTATE_GFX_CLOCK_GATING |
DSTATE_DOT_CLOCK_GATING;
I915_WRITE(D_STATE, dstate);
+
+ if (IS_PINEVIEW(dev))
+ I915_WRITE(ECOSKPD, _MASKED_BIT_ENABLE(ECO_GATING_CX_ONLY));
}
static void i85x_init_clock_gating(struct drm_device *dev)
--
1.7.10
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/i915: CR clock gating is recommend to be set on PineView
2012-04-24 13:51 ` Chris Wilson
@ 2012-04-25 9:49 ` Daniel Vetter
0 siblings, 0 replies; 3+ messages in thread
From: Daniel Vetter @ 2012-04-25 9:49 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
On Tue, Apr 24, 2012 at 02:51:43PM +0100, Chris Wilson wrote:
> The specs recommend that this bit be set on PineView. No reason is
> given, but it sounds like a powersaving bit that we should expect the
> BIOS to be setting...
>
> v2: Rebase on top of _MASKED_ENABLE_BIT
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Queued for -next, thanks for the patch.
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-04-25 9:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-24 12:36 [PATCH] drm/i915: CR clock gating is recommend to be set on PineView Chris Wilson
2012-04-24 13:51 ` Chris Wilson
2012-04-25 9:49 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox