From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: prefer wide & slow to fast & narrow in DP configs
Date: Fri, 22 Jun 2012 09:29:18 -0700 [thread overview]
Message-ID: <20120622092918.29c345d6@jbarnes-desktop> (raw)
In-Reply-To: <1340355948_38587@CP5-2952>
On Fri, 22 Jun 2012 10:05:19 +0100
Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Thu, 21 Jun 2012 18:13:19 -0700, Keith Packard <keithp@keithp.com> wrote:
> > Jesse Barnes <jbarnes@virtuousgeek.org> writes:
> >
> > > High frequency link configurations have the potential to cause trouble
> > > with long and/or cheap cables, so prefer slow and wide configurations
> > > instead. This patch has the potential to cause trouble for eDP
> > > configurations that lie about available lanes, so if we run into that we
> > > can make it conditional on eDP.
> >
> > I *have* run into this on eDP machines already, which is why the code
> > loops this way today...
>
> It was structured to minimise lane count because certain chipsets did
> not wire up all the lanes, right? Is that still relevant as we are using
> the advertised max_lane_count from the DPCD now?
In embedded applications, some of the lanes may not exist, but the DPCD
should indicate that (though as Keith says, some lie about it). But if
we set aside eDP it may be safe...
--
Jesse Barnes, Intel Open Source Technology Center
next prev parent reply other threads:[~2012-06-22 16:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-21 22:13 [PATCH] drm/i915: prefer wide & slow to fast & narrow in DP configs Jesse Barnes
2012-06-22 1:13 ` Keith Packard
2012-06-22 9:05 ` Chris Wilson
2012-06-22 14:21 ` Adam Jackson
2012-06-22 16:29 ` Jesse Barnes [this message]
2012-06-22 17:42 ` Keith Packard
2012-06-22 17:40 ` Keith Packard
2012-06-22 17:53 ` Chris Wilson
2012-07-04 7:42 ` Daniel Vetter
2012-08-06 0:12 ` [3.2.y, 3.4.y, 3.5.y] " Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120622092918.29c345d6@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox