From: Jonathan Nieder <jrnieder@gmail.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org, stable@vger.kernel.org
Subject: [3.2.y, 3.4.y, 3.5.y] Re: [PATCH] drm/i915: prefer wide & slow to fast & narrow in DP configs
Date: Sun, 5 Aug 2012 17:12:06 -0700 [thread overview]
Message-ID: <20120806001206.GA1376@Jonathans-MacBook-Air.local> (raw)
In-Reply-To: <20120704074209.GD5375@phenom.ffwll.local>
Hi Ben, Greg, et al,
Please consider
2514bc510d0c drm/i915: prefer wide & slow to fast & narrow in DP
configs, 2012-06-21
for application to the 3.2.y, 3.4.y, and 3.5.y trees.
It addresses a regression which bisects to v3.2-rc1~135^2~2^2~7
(drm/i915/dp: Fix the math in intel_dp_link_required, 2011-10-14).
An external display connected through DisplayPort would give "DP no
signal" unless the resolution was overridden to be artificially low.
In discussion of the patch, two worries came up:
- In older kernels, some machines lied about the maximum number of
DP lanes. Luckily v3.2-rc3~8^2~5^2~2 (drm/i915: Use DPCD value for
max DP lanes, 2011-11-02) solved that, so the patch should be safe.
- Using the minimum lane count is the right thing to do to minimize
power consumption. But a working display is more important.
Peter who discovered the bug tested the patch in June and found it to
work. He tried it against a 3.2.y tree in July and it still worked.
The patch has been in mainline for about a week and a half and in
Debian's 3.2.y-based kernel since around the same time. No complaints
yet.
Thoughts of all kinds welcome, as usual.
Hope that helps,
Jonathan
prev parent reply other threads:[~2012-08-06 0:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-21 22:13 [PATCH] drm/i915: prefer wide & slow to fast & narrow in DP configs Jesse Barnes
2012-06-22 1:13 ` Keith Packard
2012-06-22 9:05 ` Chris Wilson
2012-06-22 14:21 ` Adam Jackson
2012-06-22 16:29 ` Jesse Barnes
2012-06-22 17:42 ` Keith Packard
2012-06-22 17:40 ` Keith Packard
2012-06-22 17:53 ` Chris Wilson
2012-07-04 7:42 ` Daniel Vetter
2012-08-06 0:12 ` Jonathan Nieder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120806001206.GA1376@Jonathans-MacBook-Air.local \
--to=jrnieder@gmail.com \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox