From: Daniel Vetter <daniel@ffwll.ch>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: intel-gfx@lists.freedesktop.org, stable@vger.kernel.org
Subject: Re: [PATCH] drm/i915: Wait for all pending operations to the fb before disabling the pipe
Date: Wed, 12 Sep 2012 18:14:50 +0200 [thread overview]
Message-ID: <20120912161450.GS5533@phenom.ffwll.local> (raw)
In-Reply-To: <20120912160303.GC676@mannheim-rule.local>
On Wed, Sep 12, 2012 at 09:03:03AM -0700, Jonathan Nieder wrote:
> Timo Aaltonen wrote:
>
> > Well, these are usually hard to verify fixed. The commit is mentioned on
> > fdo bugs 45413 and 48838, should fix some GPU hangs.
>
> The stable kernel rules are very clear about this:
>
> - It must be obviously correct and tested.
>
> Please ensure the backport gets tested on a machine that was
> affected by the problem. That doesn't mean we need 100%
> confidence that the fix worked, but if I understand you
> correctly it is possible that nobody tested the backport on
> real hardware at all.
>
> An ack from someone on the i915 team would be welcome as well.
It's the right thing. The comment about "hough we still have a window for
userspace to submit a broken command buffer during the modeset" just
re-stresses that client can still kill the gpu. But with this fix here
userspace has at least a chance to get it right, whereas before it just
fell over sometimes.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2012-09-12 16:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1347461831-18546-1-git-send-email-timo.aaltonen@canonical.com>
2012-09-12 15:09 ` [PATCH] drm/i915: Wait for all pending operations to the fb before disabling the pipe Jonathan Nieder
2012-09-12 15:23 ` Timo Aaltonen
2012-09-12 16:03 ` Jonathan Nieder
2012-09-12 16:14 ` Daniel Vetter [this message]
2012-09-12 16:24 ` Jonathan Nieder
2012-04-17 9:05 Chris Wilson
2012-04-18 11:01 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120912161450.GS5533@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jrnieder@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox