Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Timo Aaltonen <tjaalton@ubuntu.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: intel-gfx@lists.freedesktop.org, stable@vger.kernel.org
Subject: Re: [PATCH] drm/i915: Wait for all pending operations to the fb before disabling the pipe
Date: Wed, 12 Sep 2012 18:23:47 +0300	[thread overview]
Message-ID: <5050A903.2000403@ubuntu.com> (raw)
In-Reply-To: <20120912150933.GA676@mannheim-rule.local>

On 12.09.2012 18:09, Jonathan Nieder wrote:
> Hi Timo,
> 
> Timo Aaltonen wrote:
> 
>> commit d698c826bb93663e4b349a78fbd30443654d37cd upstream.

oops, script-fail.. that's the local branch sha, real one is further
down (0f91128d88bbb8b0a8e7bb93df2c40680871d45a).

>> Please pull this for v3.2.x, should be the last missing (kernel) piece
>> for https://bugs.freedesktop.org/show_bug.cgi?id=48838
> [...]
>>              It should be more reliable to wait for the pending
>> operations to complete first, even though we still have a window for
>> userspace to submit a broken command buffer during the modeset.
> 
> That sounds hazy --- is it tested?

Well, these are usually hard to verify fixed. The commit is mentioned on
fdo bugs 45413 and 48838, should fix some GPU hangs.

> Presumably this is needed for 3.4.y and 3.5.y as well, right?  Do you
> know when the bad behavior was introduced?  Does 3.0.y need the fix as
> well?

It's from 3.5-rc1, don't know when it was introduced. Maybe it would
make sense for 3.4 at least.


-- 
t

  reply	other threads:[~2012-09-12 15:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1347461831-18546-1-git-send-email-timo.aaltonen@canonical.com>
2012-09-12 15:09 ` [PATCH] drm/i915: Wait for all pending operations to the fb before disabling the pipe Jonathan Nieder
2012-09-12 15:23   ` Timo Aaltonen [this message]
2012-09-12 16:03     ` Jonathan Nieder
2012-09-12 16:14       ` Daniel Vetter
2012-09-12 16:24         ` Jonathan Nieder
2012-04-17  9:05 Chris Wilson
2012-04-18 11:01 ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5050A903.2000403@ubuntu.com \
    --to=tjaalton@ubuntu.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jrnieder@gmail.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox