From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Wait for all pending operations to the fb before disabling the pipe
Date: Wed, 18 Apr 2012 13:01:51 +0200 [thread overview]
Message-ID: <20120418110151.GO5315@phenom.ffwll.local> (raw)
In-Reply-To: <1334653538-14646-1-git-send-email-chris@chris-wilson.co.uk>
On Tue, Apr 17, 2012 at 10:05:38AM +0100, Chris Wilson wrote:
> During modeset we have to disable the pipe to reconfigure its timings
> and maybe its size. Userspace may have queued up command buffers that
> depend upon the pipe running in a certain configuration and so the
> commands may become confused across the modeset. At the moment, we use a
> less than satisfactory kick-scanline-waits should the GPU hang during
> the modeset. It should be more reliable to wait for the pending
> operations to complete first, even though we still have a window for
> userspace to submit a broken command buffer during the modeset.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Queued for -next, thanks for the patch.
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
next prev parent reply other threads:[~2012-04-18 11:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-17 9:05 [PATCH] drm/i915: Wait for all pending operations to the fb before disabling the pipe Chris Wilson
2012-04-18 11:01 ` Daniel Vetter [this message]
[not found] <1347461831-18546-1-git-send-email-timo.aaltonen@canonical.com>
2012-09-12 15:09 ` Jonathan Nieder
2012-09-12 15:23 ` Timo Aaltonen
2012-09-12 16:03 ` Jonathan Nieder
2012-09-12 16:14 ` Daniel Vetter
2012-09-12 16:24 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120418110151.GO5315@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox