From: Daniel Vetter <daniel@ffwll.ch>
To: Ben Widawsky <ben@bwidawsk.net>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/4] drm/i915: ILK also needs that last fix
Date: Mon, 15 Oct 2012 20:59:22 +0200 [thread overview]
Message-ID: <20121015185922.GA5753@phenom.ffwll.local> (raw)
In-Reply-To: <1349318064-22051-3-git-send-email-ben@bwidawsk.net>
On Wed, Oct 03, 2012 at 07:34:23PM -0700, Ben Widawsky wrote:
> That fix was the disable render deptch cache pipeline flush
>
> Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
I've stumbled over the same one, but my docs here suggest i965g/gm45 need
it, too:
http://cgit.freedesktop.org/~danvet/drm/commit/?h=ilk-wa-pile&id=37c4c82b8cdbcf5adccad97f0b45747ba37ed659
Have you checked whether we don't need this on ivb/vlv/hsw, too?
Also, for w/a patches based on the vpg w/a database, please include the
vpg w/a name tag both in the commit message and in a code comment
somewhere.
-Daniel
> ---
> drivers/gpu/drm/i915/intel_pm.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index f1800ca..8aafa45 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -3338,6 +3338,8 @@ static void ironlake_init_clock_gating(struct drm_device *dev)
> I915_WRITE(WM2_LP_ILK, 0);
> I915_WRITE(WM1_LP_ILK, 0);
>
> + I915_WRITE(CACHE_MODE_0,
> + _MASKED_BIT_ENABLE(CM0_RC_PIPELINE_FLUSH_DISABLE));
> /*
> * Based on the document from hardware guys the following bits
> * should be set unconditionally in order to enable FBC.
> --
> 1.7.12.2
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2012-10-15 18:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-04 2:34 [PATCH 1/4] drm/i915: Remove duplicate cache workaround Ben Widawsky
2012-10-04 2:34 ` [PATCH 2/4] drm/i915: Disable render depth cache pipeline flush Ben Widawsky
2012-10-04 2:34 ` [PATCH 3/4] drm/i915: ILK also needs that last fix Ben Widawsky
2012-10-15 18:59 ` Daniel Vetter [this message]
2012-10-16 3:21 ` Ben Widawsky
2012-10-16 7:16 ` Daniel Vetter
2012-10-04 2:34 ` [PATCH 4/4] drm/i915: Fix GT_MODE default value Ben Widawsky
2012-10-04 11:25 ` Daniel Vetter
2012-10-04 7:01 ` [PATCH 1/4] drm/i915: Remove duplicate cache workaround Daniel Vetter
2012-10-04 14:55 ` Ben Widawsky
2012-10-05 0:14 ` Ben Widawsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121015185922.GA5753@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=ben@bwidawsk.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox