Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/3] drm/i915: The sprite scaler on Ironlake also support YUV planes
Date: Wed, 19 Dec 2012 14:00:59 +0200	[thread overview]
Message-ID: <20121219120058.GV29018@intel.com> (raw)
In-Reply-To: <1355868794-3708-2-git-send-email-chris@chris-wilson.co.uk>

On Tue, Dec 18, 2012 at 10:13:13PM +0000, Chris Wilson wrote:
> This fixes a regression from
> 
> commit 57779d06367a915ee03e6cb918d7575f0a46e419
> Author: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Date:   Wed Oct 31 17:50:14 2012 +0200
> 
>     drm/i915: Fix display pixel format handling
> 
> (which even says that they are supported on Ironlake, and then promptly
> rejects then...)

Sorry about that. I do remember changing the condition when changing the
commit message, but I must have made an error when resolving conflicts
during one of the rebases the patch went through.

> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>  drivers/gpu/drm/i915/intel_display.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index de09f47..211a097 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -8332,7 +8332,7 @@ int intel_framebuffer_init(struct drm_device *dev,
>  	case DRM_FORMAT_UYVY:
>  	case DRM_FORMAT_YVYU:
>  	case DRM_FORMAT_VYUY:
> -		if (INTEL_INFO(dev)->gen < 6)
> +		if (INTEL_INFO(dev)->gen < 5)
>  			return -EINVAL;
>  		break;
>  	default:
> -- 
> 1.7.10.4
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel OTC

  reply	other threads:[~2012-12-19 12:01 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-18 22:13 [PATCH 1/3] drm/i915; Protect intel_gen4_compute_offset_xtiled() against unknown pixel format Chris Wilson
2012-12-18 22:13 ` [PATCH 2/3] drm/i915: The sprite scaler on Ironlake also support YUV planes Chris Wilson
2012-12-19 12:00   ` Ville Syrjälä [this message]
2013-01-08 11:09     ` Daniel Vetter
2012-12-18 22:13 ` [PATCH 3/3] drm/i915: Add DEBUG messages to all intel_create_user_framebuffer error paths Chris Wilson
2012-12-19 11:47   ` Ville Syrjälä
2012-12-19 11:52     ` Chris Wilson
2012-12-19 11:58       ` Ville Syrjälä
2013-01-08 11:14   ` Daniel Vetter
2013-01-08 11:13 ` [PATCH 1/3] drm/i915; Protect intel_gen4_compute_offset_xtiled() against unknown pixel format Daniel Vetter
2013-01-08 11:31   ` Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121219120058.GV29018@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox