Re: [PATCH 3/3] drm/i915: Add DEBUG messages to all intel_create_user_framebuffer error paths

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Wed, Dec 19, 2012 at 11:52:11AM +0000, Chris Wilson wrote:
> On Wed, 19 Dec 2012 13:47:41 +0200, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> > On Tue, Dec 18, 2012 at 10:13:14PM +0000, Chris Wilson wrote:
> > > This proves to be very useful when investigating why code suddenly
> > > started failing.
> > > 
> > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > > ---
> > >  drivers/gpu/drm/i915/intel_display.c |   33 +++++++++++++++++++++++++--------
> > >  1 file changed, 25 insertions(+), 8 deletions(-)
> > > 
> > > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> > > index 211a097..50d6580 100644
> > > --- a/drivers/gpu/drm/i915/intel_display.c
> > > +++ b/drivers/gpu/drm/i915/intel_display.c
> > > @@ -8293,19 +8293,30 @@ int intel_framebuffer_init(struct drm_device *dev,
> > >  {
> > >  	int ret;
> > >  
> > > -	if (obj->tiling_mode == I915_TILING_Y)
> > > +	if (obj->tiling_mode == I915_TILING_Y) {
> > > +		DRM_DEBUG("hardware does not support tiling Y\n");
> > 
> > Shouldn't all of these be DRM_DEBUG_KMS()?
> 
> I choose DRM_DEBUG because these are user errors, which I think has been
> the prevailing choice in the past.

drm_crtc.c uses DRM_DEBUG_KMS for user errors too.

-- 
Ville Syrjälä
Intel OTC