From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/3] drm/i915: Add DEBUG messages to all intel_create_user_framebuffer error paths
Date: Wed, 19 Dec 2012 13:47:41 +0200 [thread overview]
Message-ID: <20121219114741.GS29018@intel.com> (raw)
In-Reply-To: <1355868794-3708-3-git-send-email-chris@chris-wilson.co.uk>
On Tue, Dec 18, 2012 at 10:13:14PM +0000, Chris Wilson wrote:
> This proves to be very useful when investigating why code suddenly
> started failing.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> drivers/gpu/drm/i915/intel_display.c | 33 +++++++++++++++++++++++++--------
> 1 file changed, 25 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 211a097..50d6580 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -8293,19 +8293,30 @@ int intel_framebuffer_init(struct drm_device *dev,
> {
> int ret;
>
> - if (obj->tiling_mode == I915_TILING_Y)
> + if (obj->tiling_mode == I915_TILING_Y) {
> + DRM_DEBUG("hardware does not support tiling Y\n");
Shouldn't all of these be DRM_DEBUG_KMS()?
--
Ville Syrjälä
Intel OTC
next prev parent reply other threads:[~2012-12-19 11:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-18 22:13 [PATCH 1/3] drm/i915; Protect intel_gen4_compute_offset_xtiled() against unknown pixel format Chris Wilson
2012-12-18 22:13 ` [PATCH 2/3] drm/i915: The sprite scaler on Ironlake also support YUV planes Chris Wilson
2012-12-19 12:00 ` Ville Syrjälä
2013-01-08 11:09 ` Daniel Vetter
2012-12-18 22:13 ` [PATCH 3/3] drm/i915: Add DEBUG messages to all intel_create_user_framebuffer error paths Chris Wilson
2012-12-19 11:47 ` Ville Syrjälä [this message]
2012-12-19 11:52 ` Chris Wilson
2012-12-19 11:58 ` Ville Syrjälä
2013-01-08 11:14 ` Daniel Vetter
2013-01-08 11:13 ` [PATCH 1/3] drm/i915; Protect intel_gen4_compute_offset_xtiled() against unknown pixel format Daniel Vetter
2013-01-08 11:31 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121219114741.GS29018@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox