From: Chris Wilson <chris@chris-wilson.co.uk>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
"for 3.8 only" <stable@vger.kernel.org>,
Mika Kuoppala <mika.kuoppala@intel.com>
Subject: Re: [PATCH] drm/i915: enable irqs earlier when resuming
Date: Tue, 5 Mar 2013 08:53:48 +0000 [thread overview]
Message-ID: <20130305085326.GA27641@cantiga.alporthouse.com> (raw)
In-Reply-To: <1362473458-9648-1-git-send-email-daniel.vetter@ffwll.ch>
On Tue, Mar 05, 2013 at 09:50:58AM +0100, Daniel Vetter wrote:
> We need it to restore the ilk rc6 context, since the gpu wait no
> requires interrupts. But in general having interrupts around should
> help in code sanity, since more and more stuff is interrupt driven.
>
> This regression has been introduced in
>
> commit 3e9605018ab3e333d51cc90fccfde2031886763b
> Author: Chris Wilson <chris@chris-wilson.co.uk>
> Date: Tue Nov 27 16:22:54 2012 +0000
>
> drm/i915: Rearrange code to only have a single method for waiting upon the ring
Not entirely, as we can also regard this as an oversight from fixing up
the irq sequence during initialisation... :-p
>
> Like in the driver load code we need to make sure that hotplug
> interrupts don't cause havoc with our modeset state, hence block them
> with the existing infrastructure. Again we ignore races where we might
> loose hotplug interrupts ...
>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=54691
> Cc: stable@vger.kernel.org (for 3.8 only)
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala@intel.com>
> Reported-and-Tested-by: Ilya Tumaykin <itumaykin@gmail.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Reviewed-by: Chris wilson <chris@chris-wilson.co.uk>
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2013-03-05 8:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-05 8:50 [PATCH] drm/i915: enable irqs earlier when resuming Daniel Vetter
2013-03-05 8:53 ` Chris Wilson [this message]
2013-03-05 9:06 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130305085326.GA27641@cantiga.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mika.kuoppala@intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox