From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Ben Widawsky <ben@bwidawsk.net>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Don't overclock on Haswell
Date: Mon, 25 Mar 2013 07:36:51 -0700 [thread overview]
Message-ID: <20130325073651.6b9b9202@jbarnes-desktop> (raw)
In-Reply-To: <1364085991-20495-1-git-send-email-ben@bwidawsk.net>
On Sat, 23 Mar 2013 17:46:31 -0700
Ben Widawsky <ben@bwidawsk.net> wrote:
> HSW doesn't overclock the same way as IVB or SNB. I do not know about
> VLV, so I've kept that off as well. I'm still working on getting the doc
> updates to explain how we overclock on Haswell.
>
> Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
> Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
> ---
> drivers/gpu/drm/i915/intel_pm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index ce3db2c..9c11dd9 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -2628,7 +2628,7 @@ static void gen6_enable_rps(struct drm_device *dev)
> (IS_HASWELL(dev) ? GEN7_RP_DOWN_IDLE_AVG : GEN6_RP_DOWN_IDLE_CONT));
>
> ret = sandybridge_pcode_write(dev_priv, GEN6_PCODE_WRITE_MIN_FREQ_TABLE, 0);
> - if (!ret) {
> + if (!ret && IS_GEN6(dev) || IS_IVYBRIDGE(dev)) {
> pcu_mbox = 0;
> ret = sandybridge_pcode_read(dev_priv, GEN6_READ_OC_PARAMS, &pcu_mbox);
> if (!ret && (pcu_mbox & (1<<31))) { /* OC supported */
This won't affect VLV, since I have a new rps enable function in my
latest set. But it looks fine.
Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
--
Jesse Barnes, Intel Open Source Technology Center
next prev parent reply other threads:[~2013-03-25 14:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-20 3:19 [PATCH] drm/i915: Correct sandybrige overclocking Ben Widawsky
2013-03-20 9:58 ` Chris Wilson
2013-03-20 16:21 ` Jesse Barnes
2013-03-20 16:33 ` Ben Widawsky
2013-03-20 16:57 ` Jesse Barnes
2013-03-20 21:47 ` Daniel Vetter
2013-03-23 19:32 ` Daniel Vetter
2013-03-23 19:39 ` Daniel Vetter
2013-03-23 23:56 ` Ben Widawsky
2013-03-24 12:06 ` Daniel Vetter
2013-03-24 0:46 ` [PATCH] drm/i915: Don't overclock on Haswell Ben Widawsky
2013-03-25 14:36 ` Jesse Barnes [this message]
2013-03-25 15:38 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130325073651.6b9b9202@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=ben@bwidawsk.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox