* [PATCH] drm/i915: tune down Y tiling scanout warning
@ 2013-04-04 16:13 Daniel Vetter
2013-04-04 16:42 ` Chris Wilson
2013-04-06 21:54 ` Daniel Vetter
0 siblings, 2 replies; 6+ messages in thread
From: Daniel Vetter @ 2013-04-04 16:13 UTC (permalink / raw)
To: Intel Graphics Development; +Cc: Daniel Vetter
Userspace can easily hit this and does since Ville added a new evil
igt testcase in:
commit 069e35e0fc3785faa562adcfd2dd7bbed4cb1dea
Author: Ville Syrjälä <ville.syrjala@linux.intel.com>
Date: Mon Mar 4 15:34:06 2013 +0200
kms_flip: Add flip-vs-bad-tiling test
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
drivers/gpu/drm/i915/intel_display.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 1b2c744..7ac7de6 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -1907,8 +1907,10 @@ intel_pin_and_fence_fb_obj(struct drm_device *dev,
alignment = 0;
break;
case I915_TILING_Y:
- /* FIXME: Is this true? */
- DRM_ERROR("Y tiled not allowed for scan out buffers\n");
+ /* Despite that we check this in framebuffer init userspace can
+ * scre us over and change the tiling after the fact. Only
+ * pinned buffers can't change their tiling. */
+ DRM_DEBUG_DRIVER("Y tiled not allowed for scan out buffers\n");
return -EINVAL;
default:
BUG();
--
1.7.10.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] drm/i915: tune down Y tiling scanout warning
2013-04-04 16:13 [PATCH] drm/i915: tune down Y tiling scanout warning Daniel Vetter
@ 2013-04-04 16:42 ` Chris Wilson
2013-04-06 17:44 ` Daniel Vetter
2013-04-06 21:54 ` Daniel Vetter
1 sibling, 1 reply; 6+ messages in thread
From: Chris Wilson @ 2013-04-04 16:42 UTC (permalink / raw)
To: Daniel Vetter; +Cc: Intel Graphics Development
On Thu, Apr 04, 2013 at 06:13:08PM +0200, Daniel Vetter wrote:
> Userspace can easily hit this and does since Ville added a new evil
> igt testcase in:
Scre? :-p
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915: tune down Y tiling scanout warning
2013-04-04 16:42 ` Chris Wilson
@ 2013-04-06 17:44 ` Daniel Vetter
2013-04-06 18:34 ` Chris Wilson
0 siblings, 1 reply; 6+ messages in thread
From: Daniel Vetter @ 2013-04-06 17:44 UTC (permalink / raw)
To: Chris Wilson, Daniel Vetter, Intel Graphics Development
On Thu, Apr 04, 2013 at 05:42:52PM +0100, Chris Wilson wrote:
> On Thu, Apr 04, 2013 at 06:13:08PM +0200, Daniel Vetter wrote:
> > Userspace can easily hit this and does since Ville added a new evil
> > igt testcase in:
>
> Scre? :-p
Context is lost on me here ...
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915: tune down Y tiling scanout warning
2013-04-06 17:44 ` Daniel Vetter
@ 2013-04-06 18:34 ` Chris Wilson
0 siblings, 0 replies; 6+ messages in thread
From: Chris Wilson @ 2013-04-06 18:34 UTC (permalink / raw)
To: Daniel Vetter; +Cc: Daniel Vetter, Intel Graphics Development
On Sat, Apr 06, 2013 at 07:44:45PM +0200, Daniel Vetter wrote:
> On Thu, Apr 04, 2013 at 05:42:52PM +0100, Chris Wilson wrote:
> > On Thu, Apr 04, 2013 at 06:13:08PM +0200, Daniel Vetter wrote:
> > > Userspace can easily hit this and does since Ville added a new evil
> > > igt testcase in:
> >
> > Scre? :-p
>
> Context is lost on me here ...
You invented a new word in the comments. Probably stepped on a loose bit
of scree.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] drm/i915: tune down Y tiling scanout warning
2013-04-04 16:13 [PATCH] drm/i915: tune down Y tiling scanout warning Daniel Vetter
2013-04-04 16:42 ` Chris Wilson
@ 2013-04-06 21:54 ` Daniel Vetter
2013-04-08 8:47 ` Daniel Vetter
1 sibling, 1 reply; 6+ messages in thread
From: Daniel Vetter @ 2013-04-06 21:54 UTC (permalink / raw)
To: Intel Graphics Development; +Cc: Daniel Vetter
Userspace can easily hit this and does since Ville added a new evil
igt testcase in:
commit 069e35e0fc3785faa562adcfd2dd7bbed4cb1dea
Author: Ville Syrjälä <ville.syrjala@linux.intel.com>
Date: Mon Mar 4 15:34:06 2013 +0200
kms_flip: Add flip-vs-bad-tiling test
v2: Fix the spelling in the added comment (Chris).
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
drivers/gpu/drm/i915/intel_display.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 1b2c744..0e799ea 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -1907,8 +1907,10 @@ intel_pin_and_fence_fb_obj(struct drm_device *dev,
alignment = 0;
break;
case I915_TILING_Y:
- /* FIXME: Is this true? */
- DRM_ERROR("Y tiled not allowed for scan out buffers\n");
+ /* Despite that we check this in framebuffer_init userspace can
+ * screw us over and change the tiling after the fact. Only
+ * pinned buffers can't change their tiling. */
+ DRM_DEBUG_DRIVER("Y tiled not allowed for scan out buffers\n");
return -EINVAL;
default:
BUG();
--
1.7.10.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] drm/i915: tune down Y tiling scanout warning
2013-04-06 21:54 ` Daniel Vetter
@ 2013-04-08 8:47 ` Daniel Vetter
0 siblings, 0 replies; 6+ messages in thread
From: Daniel Vetter @ 2013-04-08 8:47 UTC (permalink / raw)
To: Intel Graphics Development; +Cc: Daniel Vetter
On Sat, Apr 06, 2013 at 11:54:56PM +0200, Daniel Vetter wrote:
> Userspace can easily hit this and does since Ville added a new evil
> igt testcase in:
>
> commit 069e35e0fc3785faa562adcfd2dd7bbed4cb1dea
> Author: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Date: Mon Mar 4 15:34:06 2013 +0200
>
> kms_flip: Add flip-vs-bad-tiling test
>
> v2: Fix the spelling in the added comment (Chris).
>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
I've picked this up for next with a reference to the bug QA filed.
-Daniel
> ---
> drivers/gpu/drm/i915/intel_display.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 1b2c744..0e799ea 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -1907,8 +1907,10 @@ intel_pin_and_fence_fb_obj(struct drm_device *dev,
> alignment = 0;
> break;
> case I915_TILING_Y:
> - /* FIXME: Is this true? */
> - DRM_ERROR("Y tiled not allowed for scan out buffers\n");
> + /* Despite that we check this in framebuffer_init userspace can
> + * screw us over and change the tiling after the fact. Only
> + * pinned buffers can't change their tiling. */
> + DRM_DEBUG_DRIVER("Y tiled not allowed for scan out buffers\n");
> return -EINVAL;
> default:
> BUG();
> --
> 1.7.10.4
>
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-04-08 8:44 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-04 16:13 [PATCH] drm/i915: tune down Y tiling scanout warning Daniel Vetter
2013-04-04 16:42 ` Chris Wilson
2013-04-06 17:44 ` Daniel Vetter
2013-04-06 18:34 ` Chris Wilson
2013-04-06 21:54 ` Daniel Vetter
2013-04-08 8:47 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox