From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>,
ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t v4] tests/gem_tiling_max_stride: Add a test for max fence stride
Date: Tue, 9 Apr 2013 20:21:05 +0200 [thread overview]
Message-ID: <20130409182105.GF27612@phenom.ffwll.local> (raw)
In-Reply-To: <20130409180632.GO3792@cantiga.alporthouse.com>
On Tue, Apr 09, 2013 at 07:06:32PM +0100, Chris Wilson wrote:
> On Tue, Apr 09, 2013 at 05:45:37PM +0300, ville.syrjala@linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > gem_tiling_max_stride writes a data pattern to an X-tiled buffer using
> > the maximum supported stride, reads the data back as linear, and
> > verifies that the data didn't get scrambled on the way.
> >
> > The test also checks that some invalid stride values are rejected
> > properly.
> >
> > v2: Check invalid strides
> > v3: Check invalid stride with Y-tiling
> > Include a few more invalid stride values
> > Fix gen3 X-tile size
> > v4: A few more invalid strides :)
> > Drop the useless memset()
> >
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> I think I've exhausted my wishlist, and congrats on finding the bug, so
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Merged all three patches, thanks a lot for supplying paranoid igt cases.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2013-04-09 18:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-09 12:25 [PATCH i-g-t 0/3] Fence register stuff ville.syrjala
2013-04-09 12:25 ` [PATCH i-g-t 1/3] tests/gem_fenced_exec_thrash: Increase MAX_FENCES to 32 ville.syrjala
2013-04-09 13:05 ` Chris Wilson
2013-04-11 17:43 ` [PATCH] tests/gem_fenced_exec_thrash: Test with > max fences ville.syrjala
2013-04-11 18:22 ` Daniel Vetter
2013-04-09 12:25 ` [PATCH i-g-t 2/3] tests: Use gem_available_fences() ville.syrjala
2013-04-09 12:25 ` [PATCH i-g-t 3/3] tests/gem_tiling_max_stride: Add a test for max fence stride ville.syrjala
2013-04-09 13:06 ` Chris Wilson
2013-04-09 13:41 ` [PATCH i-g-t v2] " ville.syrjala
2013-04-09 13:51 ` Chris Wilson
2013-04-09 14:45 ` [PATCH i-g-t v4] " ville.syrjala
2013-04-09 18:06 ` Chris Wilson
2013-04-09 18:21 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130409182105.GF27612@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox