* [PATCH] drm/i915: Kill useless "Enable panel fitter" comments
@ 2013-06-13 22:51 Daniel Vetter
2013-06-14 1:19 ` Jesse Barnes
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Vetter @ 2013-06-13 22:51 UTC (permalink / raw)
To: Intel Graphics Development; +Cc: Daniel Vetter
Now that we have this all nicely abstract into separate functions with
self-documenting names this is pointless. And as Yuly Novikov spotted
in the case of ilk-ivb also wrong since we use the pfit both for lvds
and eDP
Reported-By: Yuly Novikov <ynovikov@chromium.org>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
drivers/gpu/drm/i915/intel_display.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index e1184eb..2338279 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -3209,7 +3209,6 @@ static void ironlake_crtc_enable(struct drm_crtc *crtc)
assert_fdi_rx_disabled(dev_priv, pipe);
}
- /* Enable panel fitting for LVDS */
ironlake_pfit_enable(intel_crtc);
/*
@@ -3315,7 +3314,6 @@ static void haswell_crtc_enable(struct drm_crtc *crtc)
intel_ddi_enable_pipe_clock(intel_crtc);
- /* Enable panel fitting for eDP */
ironlake_pfit_enable(intel_crtc);
/*
@@ -3611,7 +3609,6 @@ static void valleyview_crtc_enable(struct drm_crtc *crtc)
for_each_encoder_on_crtc(dev, crtc, encoder)
encoder->enable(encoder);
- /* Enable panel fitting for eDP */
i9xx_pfit_enable(intel_crtc);
intel_crtc_load_lut(crtc);
@@ -3649,7 +3646,6 @@ static void i9xx_crtc_enable(struct drm_crtc *crtc)
i9xx_enable_pll(intel_crtc);
- /* Enable panel fitting for LVDS */
i9xx_pfit_enable(intel_crtc);
intel_crtc_load_lut(crtc);
--
1.7.11.7
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/i915: Kill useless "Enable panel fitter" comments
2013-06-13 22:51 [PATCH] drm/i915: Kill useless "Enable panel fitter" comments Daniel Vetter
@ 2013-06-14 1:19 ` Jesse Barnes
2013-06-14 7:16 ` Daniel Vetter
0 siblings, 1 reply; 3+ messages in thread
From: Jesse Barnes @ 2013-06-14 1:19 UTC (permalink / raw)
To: Daniel Vetter; +Cc: Intel Graphics Development
On Fri, 14 Jun 2013 00:51:23 +0200
Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> Now that we have this all nicely abstract into separate functions with
> self-documenting names this is pointless. And as Yuly Novikov spotted
> in the case of ilk-ivb also wrong since we use the pfit both for lvds
> and eDP
>
> Reported-By: Yuly Novikov <ynovikov@chromium.org>
> Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> drivers/gpu/drm/i915/intel_display.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index e1184eb..2338279 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -3209,7 +3209,6 @@ static void ironlake_crtc_enable(struct drm_crtc *crtc)
> assert_fdi_rx_disabled(dev_priv, pipe);
> }
>
> - /* Enable panel fitting for LVDS */
> ironlake_pfit_enable(intel_crtc);
>
> /*
> @@ -3315,7 +3314,6 @@ static void haswell_crtc_enable(struct drm_crtc *crtc)
>
> intel_ddi_enable_pipe_clock(intel_crtc);
>
> - /* Enable panel fitting for eDP */
> ironlake_pfit_enable(intel_crtc);
>
> /*
> @@ -3611,7 +3609,6 @@ static void valleyview_crtc_enable(struct drm_crtc *crtc)
> for_each_encoder_on_crtc(dev, crtc, encoder)
> encoder->enable(encoder);
>
> - /* Enable panel fitting for eDP */
> i9xx_pfit_enable(intel_crtc);
>
> intel_crtc_load_lut(crtc);
> @@ -3649,7 +3646,6 @@ static void i9xx_crtc_enable(struct drm_crtc *crtc)
>
> i9xx_enable_pll(intel_crtc);
>
> - /* Enable panel fitting for LVDS */
> i9xx_pfit_enable(intel_crtc);
>
> intel_crtc_load_lut(crtc);
Acked-by: Jesse Barnes <jbarnes@virtuousgeek.org>
--
Jesse Barnes, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/i915: Kill useless "Enable panel fitter" comments
2013-06-14 1:19 ` Jesse Barnes
@ 2013-06-14 7:16 ` Daniel Vetter
0 siblings, 0 replies; 3+ messages in thread
From: Daniel Vetter @ 2013-06-14 7:16 UTC (permalink / raw)
To: Jesse Barnes; +Cc: Daniel Vetter, Intel Graphics Development
On Thu, Jun 13, 2013 at 06:19:39PM -0700, Jesse Barnes wrote:
> On Fri, 14 Jun 2013 00:51:23 +0200
> Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
>
> > Now that we have this all nicely abstract into separate functions with
> > self-documenting names this is pointless. And as Yuly Novikov spotted
> > in the case of ilk-ivb also wrong since we use the pfit both for lvds
> > and eDP
> >
> > Reported-By: Yuly Novikov <ynovikov@chromium.org>
> > Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> > ---
> > drivers/gpu/drm/i915/intel_display.c | 4 ----
> > 1 file changed, 4 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> > index e1184eb..2338279 100644
> > --- a/drivers/gpu/drm/i915/intel_display.c
> > +++ b/drivers/gpu/drm/i915/intel_display.c
> > @@ -3209,7 +3209,6 @@ static void ironlake_crtc_enable(struct drm_crtc *crtc)
> > assert_fdi_rx_disabled(dev_priv, pipe);
> > }
> >
> > - /* Enable panel fitting for LVDS */
> > ironlake_pfit_enable(intel_crtc);
> >
> > /*
> > @@ -3315,7 +3314,6 @@ static void haswell_crtc_enable(struct drm_crtc *crtc)
> >
> > intel_ddi_enable_pipe_clock(intel_crtc);
> >
> > - /* Enable panel fitting for eDP */
> > ironlake_pfit_enable(intel_crtc);
> >
> > /*
> > @@ -3611,7 +3609,6 @@ static void valleyview_crtc_enable(struct drm_crtc *crtc)
> > for_each_encoder_on_crtc(dev, crtc, encoder)
> > encoder->enable(encoder);
> >
> > - /* Enable panel fitting for eDP */
> > i9xx_pfit_enable(intel_crtc);
> >
> > intel_crtc_load_lut(crtc);
> > @@ -3649,7 +3646,6 @@ static void i9xx_crtc_enable(struct drm_crtc *crtc)
> >
> > i9xx_enable_pll(intel_crtc);
> >
> > - /* Enable panel fitting for LVDS */
> > i9xx_pfit_enable(intel_crtc);
> >
> > intel_crtc_load_lut(crtc);
>
> Acked-by: Jesse Barnes <jbarnes@virtuousgeek.org>
And now merged to dinq.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-06-14 7:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-13 22:51 [PATCH] drm/i915: Kill useless "Enable panel fitter" comments Daniel Vetter
2013-06-14 1:19 ` Jesse Barnes
2013-06-14 7:16 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox